Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2020903002:
cc: Remove RSLLMembershipWithScale test from DrMemory blacklist (Closed)
Descriptioncc: Remove RSLLMembershipWithScale test from DrMemory blacklist
Since we increased timeout for cc tests in 579189, this test should
pass.
BUG=460581
R=enne@chromium.org, danakj@chromium.org, vmpstr@chromium.org
Committed: https://crrev.com/28f9111d6b84ca3c5479ce4c52e36cf0448afc36
Cr-Commit-Position: refs/heads/master@{#405487}
Patch Set 1 #
Messages
Total messages: 20 (5 generated)
The CQ bit was checked by lof84@yandex-team.ru to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2020903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2020903002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
This patch and the other two look fine to me if you can get each of them to pass a dr memory try bot.
LGTM
On 2016/05/31 18:57:19, enne wrote: > This patch and the other two look fine to me if you can get each of them to pass > a dr memory try bot. Ya this. :)
On 2016/05/31 18:59:22, danakj wrote: > Ya this. :) I don't know why patch couldn't apply :( From log (bot_update bot_update [83GB/249GB used (33%)] PATCH FAILED ): Applying the patch from https://codereview.chromium.org/2020903002/#ps1 DEBUG subprocess2( 215): git apply --index -3 -p1 --verbose; cwd=E:\b\build\slave\win-drmemory\build\src Failed to apply patch for tools/valgrind/gtest_exclude/cc_unittests.gtest-drmemory_win32.txt: While running git apply --index -3 -p1 --verbose; Checking patch tools/valgrind/gtest_exclude/cc_unittests.gtest-drmemory_win32.txt... error: tools/valgrind/gtest_exclude/cc_unittests.gtest-drmemory_win32.txt: does not exist in index
enne@chromium.org changed reviewers: + bruening@chromium.org
+bruening, do you know why this wouldn't apply?
On 2016/05/31 21:22:40, enne wrote: > +bruening, do you know why this wouldn't apply? DrMemory trybots still don’t work :( Let we try to commit this patch. If any problem happens, then we can revert it.
On 2016/05/31 21:22:40, enne wrote: > +bruening, do you know why this wouldn't apply? Nope, the patch looks quite normal. Someone was talking about renaming tools/valgrind, maybe that went in? I have seen unexplained CQ failures before: I would just commit it manually (it will not affect the Cr build, only the MFYI waterfall).
Could I commit it? Anyway, we can revert it.
The CQ bit was checked by glider@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== cc: Remove RSLLMembershipWithScale test from DrMemory blacklist Since we increased timeout for cc tests in 579189, this test should pass. BUG=460581 R=enne@chromium.org, danakj@chromium.org, vmpstr@chromium.org ========== to ========== cc: Remove RSLLMembershipWithScale test from DrMemory blacklist Since we increased timeout for cc tests in 579189, this test should pass. BUG=460581 R=enne@chromium.org, danakj@chromium.org, vmpstr@chromium.org Committed: https://crrev.com/28f9111d6b84ca3c5479ce4c52e36cf0448afc36 Cr-Commit-Position: refs/heads/master@{#405487} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/28f9111d6b84ca3c5479ce4c52e36cf0448afc36 Cr-Commit-Position: refs/heads/master@{#405487} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
