Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentRequestDetailsTest.cpp

Issue 2020883002: PaymentRequest: Introduce PaymentMethodData. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/payments/PaymentRequestDetailsTest.cpp
diff --git a/third_party/WebKit/Source/modules/payments/PaymentRequestDetailsTest.cpp b/third_party/WebKit/Source/modules/payments/PaymentRequestDetailsTest.cpp
index 8a96b3fe12de5a5765997851e93abc8679229c49..9e302b5ef2564a919b0c84ae9601627d277861e8 100644
--- a/third_party/WebKit/Source/modules/payments/PaymentRequestDetailsTest.cpp
+++ b/third_party/WebKit/Source/modules/payments/PaymentRequestDetailsTest.cpp
@@ -77,9 +77,16 @@ private:
TrackExceptionState m_exceptionState;
};
+HeapVector<PaymentMethodData> buildPaymentMethodDataForTest()
please use gerrit instead 2016/05/29 19:57:12 Rename PaymentDetailsTestHelper into PaymentTestHe
zino 2016/06/01 17:43:46 Done.
+{
+ HeapVector<PaymentMethodData> methodData(1, PaymentMethodData());
+ methodData[0].setSupportedMethods(Vector<String>(1, "food"));
please use gerrit instead 2016/05/29 19:57:12 "foo" ?
zino 2016/06/01 17:43:46 Done.
+ return methodData;
+}
+
TEST_P(PaymentRequestDetailsTest, ValidatesDetails)
{
- PaymentRequest::create(getScriptState(), Vector<String>(1, "foo"), GetParam().buildDetails(), getExceptionState());
+ PaymentRequest::create(getScriptState(), buildPaymentMethodDataForTest(), GetParam().buildDetails(), getExceptionState());
EXPECT_EQ(GetParam().expectException(), getExceptionState().hadException());
if (GetParam().expectException())

Powered by Google App Engine
This is Rietveld 408576698