Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2020873002: Do not skip optparse import

Created:
4 years, 6 months ago by luca020400
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not skip optparse import Remove the -S option when invoking the script to allow implicit 'import optparse' by the python runtime. BUG=615617 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/safe_browsing/gen_file_type_proto.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2020873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2020873002/1
4 years, 6 months ago (2016-05-28 11:32:56 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-05-28 11:32:58 UTC) #6
No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

Powered by Google App Engine
This is Rietveld 408576698