Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 2020843002: Make test.dart override only those dependencies declared in the pubspec.yaml (Closed)

Created:
4 years, 6 months ago by Siggi Cherem (dart-lang)
Modified:
4 years, 6 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make test.dart override only those dependencies declared in the pubspec.yaml file. BUG= http://dartbug.com/26563 R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/bcfdd3345b141a42f06cccac129350cdf16f53ff

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -4 lines) Patch
M DEPS View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/pkgbuild.status View 1 chunk +0 lines, -1 line 0 comments Download
A tools/.packages View 1 chunk +9 lines, -0 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 3 chunks +25 lines, -1 line 0 comments Download
M tools/testing/dart/test_suite.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Siggi Cherem (dart-lang)
4 years, 6 months ago (2016-05-27 23:48:39 UTC) #5
Bill Hesse
lgtm
4 years, 6 months ago (2016-05-28 00:01:43 UTC) #7
Siggi Cherem (dart-lang)
FYI I forgot to put the link earlier This is to address this issue: https://github.com/dart-lang/sdk/issues/26563
4 years, 6 months ago (2016-05-28 00:18:45 UTC) #8
Siggi Cherem (dart-lang)
4 years, 6 months ago (2016-05-28 00:19:52 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:60001) manually as
bcfdd3345b141a42f06cccac129350cdf16f53ff (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698