components/offline_pages/background/BUILD.gn - Issue 2020833002: Add the request picker and a unit test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/background/BUILD.gn

Issue 2020833002: Add the request picker and a unit test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: CR feedback per Dimich and DougArnett Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/offline_pages/background/BUILD.gn

diff --git a/components/offline_pages/background/BUILD.gn b/components/offline_pages/background/BUILD.gn

index dd373da15454388ed7e0e0892de443511becf987..b0b12ca1630653bc8e18c5ca276b21cc6be16a21 100644

--- a/components/offline_pages/background/BUILD.gn

+++ b/components/offline_pages/background/BUILD.gn

@@ -14,6 +14,8 @@ static_library("background_offliner") {

"offliner_policy.h",

"request_coordinator.cc",

"request_coordinator.h",

+ "request_picker.cc",

+ "request_picker.h",

"request_queue.cc",

"request_queue.h",

"request_queue_in_memory_store.cc",

@@ -37,6 +39,7 @@ source_set("unit_tests") {

testonly = true

sources = [

"request_coordinator_unittest.cc",

+ "request_picker_unittest.cc",

"request_queue_in_memory_store_unittest.cc",

"request_queue_unittest.cc",

"save_page_request_unittest.cc",