google_apis/gcm/gcm.gyp - Issue 202083005: Add activity recording capability to gcm internals page. User can refresh, start/stop recording, an…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gcm/gcm.gyp

Issue 202083005: Add activity recording capability to gcm internals page. User can refresh, start/stop recording, an… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing zea's comments. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: google_apis/gcm/gcm.gyp

diff --git a/google_apis/gcm/gcm.gyp b/google_apis/gcm/gcm.gyp

index 98437763d72ece3ac8607c981884394c45ee3a5e..dd00c92f3dcb977b426fa44a4ff4ba159a4041f3 100644

--- a/google_apis/gcm/gcm.gyp

+++ b/google_apis/gcm/gcm.gyp

@@ -72,6 +72,8 @@

'gcm_client.h',

'gcm_client_impl.cc',

'gcm_client_impl.h',

+ 'gcm_stats_recorder.cc',

fgorski 2014/03/29 05:09:29 zea@ does it make sense to have gcm_stats_recorder

juyik 2014/03/31 22:19:23 I'll let zea@ comment on this.

+ 'gcm_stats_recorder.h',

'protocol/android_checkin.proto',

'protocol/checkin.proto',

'protocol/mcs.proto',

@@ -138,7 +140,8 @@

'engine/mcs_client_unittest.cc',

'engine/registration_request_unittest.cc',

'engine/unregistration_request_unittest.cc',

- 'gcm_client_impl_unittest.cc'

+ 'gcm_client_impl_unittest.cc',

+ 'gcm_stats_recorder_unittest.cc'

]

« google_apis/gcm/engine/mcs_client.cc ('K') | « google_apis/gcm/engine/mcs_client_unittest.cc ('k') | google_apis/gcm/gcm_client.h » ('j') | google_apis/gcm/gcm_client_impl.cc » ('J')