Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: chrome/browser/services/gcm/gcm_profile_service.h

Issue 202083005: Add activity recording capability to gcm internals page. User can refresh, start/stop recording, an… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing zea's comments. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/services/gcm/gcm_profile_service.h
diff --git a/chrome/browser/services/gcm/gcm_profile_service.h b/chrome/browser/services/gcm/gcm_profile_service.h
index 39b72663414857cf1cfa4029cef733d4c56085a2..a1d43097feb23c90f6e84c8cd02da066bc17096d 100644
--- a/chrome/browser/services/gcm/gcm_profile_service.h
+++ b/chrome/browser/services/gcm/gcm_profile_service.h
@@ -126,8 +126,13 @@ class GCMProfileService : public KeyedService,
bool IsGCMClientReady() const;
// Get GCM client internal states and statistics. If it has not been created
- // then stats won't be modified.
- void RequestGCMStatistics(RequestGCMStatisticsCallback callback);
+ // then stats won't be modified. If clear_logs is true then activity logs will
+ // be cleared before the stats are returned.
+ void RequestGCMStatistics(RequestGCMStatisticsCallback callback,
fgorski 2014/03/29 05:09:29 nit: GetGCMStatistics
juyik 2014/03/31 22:19:23 Done.
+ bool clear_logs);
+
+ // Enables/disables GCM activity recording, and then returns the stats.
+ void SetGCMRecording(RequestGCMStatisticsCallback callback, bool recording);
private:
friend class GCMProfileServiceTestConsumer;

Powered by Google App Engine
This is Rietveld 408576698