Add activity recording capability to gcm internals page. User can refresh, start/stop recording, an…

chrome/browser/services/gcm/gcm_profile_service.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SERVICES_GCM_GCM_PROFILE_SERVICE_H_
 #define CHROME_BROWSER_SERVICES_GCM_GCM_PROFILE_SERVICE_H_
 
 #include <map>
 #include <string>
 
@@ skipping 108 matching lines @@
   // For testing purpose.
   GCMClient* GetGCMClientForTesting() const;
 
   // Returns the user name if the profile is signed in.
   std::string SignedInUserName() const;
 
   // Returns true if the gcm client is ready.
   bool IsGCMClientReady() const;
 
   // Get GCM client internal states and statistics. If it has not been created
-  // then stats won't be modified.
-  void RequestGCMStatistics(RequestGCMStatisticsCallback callback);
+  // then stats won't be modified. If clear_logs is true then activity logs will
+  // be cleared before the stats are returned.
+  void RequestGCMStatistics(RequestGCMStatisticsCallback callback,
+                            bool clear_logs);
+
+  // Enables/disables GCM activity recording, and then returns the stats.

[jianli, 2014/03/26 20:17:18]

When recording is stopped, do we need to return the stats?

[juyik, 2014/03/26 20:57:32]

The stats also contains snapshots (registered app ids, etc), so even if the
recording stops, these snapshots may still have changed. Another thing I'm
trying to accomplish is: whenever the user took an action (start/stop recording,
clearing the log, etc) the screen will always be refreshed with new information
(snapshot and logs). I think that would be a good user experience.

+  void SetGCMRecording(RequestGCMStatisticsCallback callback, bool recording);
 
  private:
   friend class GCMProfileServiceTestConsumer;
 
   class DelayedTaskController;
   class IOWorker;
 
   typedef std::map<std::string, GCMAppHandler*> GCMAppHandlerMap;
 
   // Overridden from content::NotificationObserver:
@@ skipping 92 matching lines @@
 
   // Used to pass a weak pointer to the IO worker.
   base::WeakPtrFactory<GCMProfileService> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(GCMProfileService);
 };
 
 }  // namespace gcm
 
 #endif  // CHROME_BROWSER_SERVICES_GCM_GCM_PROFILE_SERVICE_H_