Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 202083003: Fix unsafe shape_plan->face dependency (Closed)

Created:
6 years, 9 months ago by Xianzhu
Modified:
6 years, 9 months ago
Reviewers:
eae, behdad
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M third_party/harfbuzz-ng/src/hb-ot-shape-private.hh View 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-shape-plan.cc View 5 chunks +3 lines, -8 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-shape-plan-private.hh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (0 generated)
Xianzhu
The update from 0.9.24 -> 0.9.26 broke some layout tests. I've reverted the update and ...
6 years, 9 months ago (2014-03-17 17:14:08 UTC) #1
behdad
lgtm
6 years, 9 months ago (2014-03-17 17:34:23 UTC) #2
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
6 years, 9 months ago (2014-03-17 17:44:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/202083003/1
6 years, 9 months ago (2014-03-17 17:44:42 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-17 17:44:43 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 9 months ago (2014-03-17 17:44:43 UTC) #6
Xianzhu
6 years, 9 months ago (2014-03-17 17:45:53 UTC) #7
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
6 years, 9 months ago (2014-03-17 18:00:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/202083003/1
6 years, 9 months ago (2014-03-17 18:02:00 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-17 18:04:00 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 9 months ago (2014-03-17 18:04:01 UTC) #11
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
6 years, 9 months ago (2014-03-17 18:07:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/202083003/1
6 years, 9 months ago (2014-03-17 18:08:46 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-17 18:12:03 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_clang_dbg tryserver.chromium on linux_chromium_chromeos_rel tryserver.chromium on linux_chromium_clang_dbg ...
6 years, 9 months ago (2014-03-17 18:12:04 UTC) #15
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
6 years, 9 months ago (2014-03-17 18:20:40 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/202083003/1
6 years, 9 months ago (2014-03-17 18:21:01 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-17 19:46:42 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 9 months ago (2014-03-17 19:46:42 UTC) #19
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
6 years, 9 months ago (2014-03-17 20:14:46 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/202083003/1
6 years, 9 months ago (2014-03-17 20:15:53 UTC) #21
commit-bot: I haz the power
Change committed as 257509
6 years, 9 months ago (2014-03-17 23:00:23 UTC) #22
eae
6 years, 9 months ago (2014-03-17 23:11:28 UTC) #23
Message was sent while issue was closed.
LGTM (post-facto)

Powered by Google App Engine
This is Rietveld 408576698