src/ia32/code-stubs-ia32.cc - Issue 202083002: [ia32/x64] Smaller instruction to check NaN

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/code-stubs-ia32.cc

Issue 202083002: [ia32/x64] Smaller instruction to check NaN (Closed) Base URL: git://github.com/v8/v8.git@master

Patch Set: only NaN related code remains Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/code-stubs-ia32.cc

diff --git a/src/ia32/code-stubs-ia32.cc b/src/ia32/code-stubs-ia32.cc

index 4ff8a6817a502a3b160b3d51171cd536f4ea52fd..466786cf3f5b3205c26b8d1b5cf6a38518beddf3 100644

--- a/src/ia32/code-stubs-ia32.cc

+++ b/src/ia32/code-stubs-ia32.cc

@@ -845,8 +845,8 @@ void MathPowStub::Generate(MacroAssembler* masm) {

__ bind(&try_arithmetic_simplification);

// Skip to runtime if possibly NaN (indicated by the indefinite integer).

__ cvttsd2si(exponent, Operand(double_exponent));

- __ cmp(exponent, Immediate(0x80000000u));

- __ j(equal, &call_runtime);

+ __ cmp(exponent, Immediate(0x1));

+ __ j(overflow, &call_runtime);

if (exponent_type_ == ON_STACK) {

// Detect square root case. Crankshaft detects constant +/-0.5 at

« no previous file with comments | « src/ia32/assembler-ia32.cc ('k') | src/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »