src/ia32/full-codegen-ia32.cc - Issue 202083002: [ia32/x64] Smaller instruction to check NaN

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/full-codegen-ia32.cc

Issue 202083002: [ia32/x64] Smaller instruction to check NaN (Closed) Base URL: git://github.com/v8/v8.git@master

Patch Set: some refine based on comments Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/full-codegen-ia32.cc

diff --git a/src/ia32/full-codegen-ia32.cc b/src/ia32/full-codegen-ia32.cc

index 06da7ba0e7d521844523e756106ee2e090756ac6..d529f30e7805e14fd3c947fb307328c4034fb643 100644

--- a/src/ia32/full-codegen-ia32.cc

+++ b/src/ia32/full-codegen-ia32.cc

@@ -3093,8 +3093,8 @@ void FullCodeGenerator::EmitIsMinusZero(CallRuntime* expr) {

Handle<Map> map = masm()->isolate()->factory()->heap_number_map();

__ CheckMap(eax, map, if_false, DO_SMI_CHECK);

- __ cmp(FieldOperand(eax, HeapNumber::kExponentOffset), Immediate(0x80000000));

- __ j(not_equal, if_false);

+ __ cmp(FieldOperand(eax, HeapNumber::kExponentOffset), Immediate(0x1));

+ __ j(no_overflow, if_false);

__ cmp(FieldOperand(eax, HeapNumber::kMantissaOffset), Immediate(0x00000000));

PrepareForBailoutBeforeSplit(expr, true, if_true, if_false);

Split(equal, if_true, if_false, fall_through);