src/ia32/assembler-ia32.cc - Issue 202083002: [ia32/x64] Smaller instruction to check NaN

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/assembler-ia32.cc

Issue 202083002: [ia32/x64] Smaller instruction to check NaN (Closed) Base URL: git://github.com/v8/v8.git@master

Patch Set: some refine based on comments Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: src/ia32/assembler-ia32.cc

diff --git a/src/ia32/assembler-ia32.cc b/src/ia32/assembler-ia32.cc

index acc36f4de9d96721870870da448b2aa839d60b4f..183f0c0b028445f39c0fcf6b3dee9fd7811d2e08 100644

--- a/src/ia32/assembler-ia32.cc

+++ b/src/ia32/assembler-ia32.cc

@@ -2568,7 +2568,7 @@ void Assembler::RecordComment(const char* msg, bool force) {

void Assembler::GrowBuffer() {

- ASSERT(overflow());

+ ASSERT(buffer_overflow());

if (!own_buffer_) FATAL("external code buffer is too small");

// Compute new buffer size.

@@ -2627,7 +2627,7 @@ void Assembler::GrowBuffer() {

}

- ASSERT(!overflow());

+ ASSERT(!buffer_overflow());

}