Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: src/x64/macro-assembler-x64.cc

Issue 202083002: [ia32/x64] Smaller instruction to check NaN (Closed) Base URL: git://github.com/v8/v8.git@master
Patch Set: some refine based on comments Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3041 matching lines...) Expand 10 before | Expand all | Expand 10 after
3052 3052
3053 CompareMap(obj, map); 3053 CompareMap(obj, map);
3054 j(not_equal, fail); 3054 j(not_equal, fail);
3055 } 3055 }
3056 3056
3057 3057
3058 void MacroAssembler::ClampUint8(Register reg) { 3058 void MacroAssembler::ClampUint8(Register reg) {
3059 Label done; 3059 Label done;
3060 testl(reg, Immediate(0xFFFFFF00)); 3060 testl(reg, Immediate(0xFFFFFF00));
3061 j(zero, &done, Label::kNear); 3061 j(zero, &done, Label::kNear);
3062 setcc(negative, reg); // 1 if negative, 0 if positive. 3062 sarl(reg, Immediate(31));
3063 decb(reg); // 0 if negative, 255 if positive. 3063 notl(reg); // safe not to zero extension
3064 bind(&done); 3064 bind(&done);
3065 } 3065 }
3066 3066
3067 3067
3068 void MacroAssembler::ClampDoubleToUint8(XMMRegister input_reg, 3068 void MacroAssembler::ClampDoubleToUint8(XMMRegister input_reg,
3069 XMMRegister temp_xmm_reg, 3069 XMMRegister temp_xmm_reg,
3070 Register result_reg) { 3070 Register result_reg) {
3071 Label done; 3071 Label done;
3072 Label conv_failure; 3072 Label conv_failure;
3073 xorps(temp_xmm_reg, temp_xmm_reg); 3073 xorps(temp_xmm_reg, temp_xmm_reg);
3074 cvtsd2si(result_reg, input_reg); 3074 cvtsd2si(result_reg, input_reg);
3075 testl(result_reg, Immediate(0xFFFFFF00)); 3075 testl(result_reg, Immediate(0xFFFFFF00));
3076 j(zero, &done, Label::kNear); 3076 j(zero, &done, Label::kNear);
3077 cmpl(result_reg, Immediate(0x80000000)); 3077 cmpl(result_reg, Immediate(1));
3078 j(equal, &conv_failure, Label::kNear); 3078 j(overflow, &conv_failure, Label::kNear);
3079 movl(result_reg, Immediate(0)); 3079 sarl(result_reg, Immediate(31));
3080 setcc(above, result_reg); 3080 notl(result_reg); // safe not to zero extension
3081 subl(result_reg, Immediate(1));
3082 andl(result_reg, Immediate(255));
3083 jmp(&done, Label::kNear); 3081 jmp(&done, Label::kNear);
3084 bind(&conv_failure); 3082 bind(&conv_failure);
3083 sarl(result_reg, Immediate(31));
3084 ucomisd(input_reg, temp_xmm_reg);
3085 j(above_equal, &done, Label::kNear);
3085 Set(result_reg, 0); 3086 Set(result_reg, 0);
3086 ucomisd(input_reg, temp_xmm_reg);
3087 j(below, &done, Label::kNear);
3088 Set(result_reg, 255);
3089 bind(&done); 3087 bind(&done);
3090 } 3088 }
3091 3089
3092 3090
3093 void MacroAssembler::LoadUint32(XMMRegister dst, 3091 void MacroAssembler::LoadUint32(XMMRegister dst,
3094 Register src, 3092 Register src,
3095 XMMRegister scratch) { 3093 XMMRegister scratch) {
3096 if (FLAG_debug_code) { 3094 if (FLAG_debug_code) {
3097 cmpq(src, Immediate(0xffffffff)); 3095 cmpq(src, Immediate(0xffffffff));
3098 Assert(below_equal, kInputGPRIsExpectedToHaveUpper32Cleared); 3096 Assert(below_equal, kInputGPRIsExpectedToHaveUpper32Cleared);
3099 } 3097 }
3100 cvtqsi2sd(dst, src); 3098 cvtqsi2sd(dst, src);
3101 } 3099 }
3102 3100
3103 3101
3104 void MacroAssembler::SlowTruncateToI(Register result_reg, 3102 void MacroAssembler::SlowTruncateToI(Register result_reg,
3105 Register input_reg, 3103 Register input_reg,
3106 int offset) { 3104 int offset) {
3107 DoubleToIStub stub(input_reg, result_reg, offset, true); 3105 DoubleToIStub stub(input_reg, result_reg, offset, true);
3108 call(stub.GetCode(isolate()), RelocInfo::CODE_TARGET); 3106 call(stub.GetCode(isolate()), RelocInfo::CODE_TARGET);
3109 } 3107 }
3110 3108
3111 3109
3112 void MacroAssembler::TruncateHeapNumberToI(Register result_reg, 3110 void MacroAssembler::TruncateHeapNumberToI(Register result_reg,
3113 Register input_reg) { 3111 Register input_reg) {
3114 Label done; 3112 Label done;
3115 movsd(xmm0, FieldOperand(input_reg, HeapNumber::kValueOffset)); 3113 movsd(xmm0, FieldOperand(input_reg, HeapNumber::kValueOffset));
3116 cvttsd2siq(result_reg, xmm0); 3114 cvttsd2siq(result_reg, xmm0);
3117 Set(kScratchRegister, V8_UINT64_C(0x8000000000000000)); 3115 cmpq(result_reg, Immediate(1));
3118 cmpq(result_reg, kScratchRegister); 3116 j(no_overflow, &done, Label::kNear);
3119 j(not_equal, &done, Label::kNear);
3120 3117
3121 // Slow case. 3118 // Slow case.
3122 if (input_reg.is(result_reg)) { 3119 if (input_reg.is(result_reg)) {
3123 subq(rsp, Immediate(kDoubleSize)); 3120 subq(rsp, Immediate(kDoubleSize));
3124 movsd(MemOperand(rsp, 0), xmm0); 3121 movsd(MemOperand(rsp, 0), xmm0);
3125 SlowTruncateToI(result_reg, rsp, 0); 3122 SlowTruncateToI(result_reg, rsp, 0);
3126 addq(rsp, Immediate(kDoubleSize)); 3123 addq(rsp, Immediate(kDoubleSize));
3127 } else { 3124 } else {
3128 SlowTruncateToI(result_reg, input_reg); 3125 SlowTruncateToI(result_reg, input_reg);
3129 } 3126 }
3130 3127
3131 bind(&done); 3128 bind(&done);
3132 } 3129 }
3133 3130
3134 3131
3135 void MacroAssembler::TruncateDoubleToI(Register result_reg, 3132 void MacroAssembler::TruncateDoubleToI(Register result_reg,
3136 XMMRegister input_reg) { 3133 XMMRegister input_reg) {
3137 Label done; 3134 Label done;
3138 cvttsd2siq(result_reg, input_reg); 3135 cvttsd2siq(result_reg, input_reg);
3139 movq(kScratchRegister, V8_INT64_C(0x8000000000000000)); 3136 cmpq(result_reg, Immediate(1));
3140 cmpq(result_reg, kScratchRegister); 3137 j(no_overflow, &done, Label::kNear);
3141 j(not_equal, &done, Label::kNear);
3142 3138
3143 subq(rsp, Immediate(kDoubleSize)); 3139 subq(rsp, Immediate(kDoubleSize));
3144 movsd(MemOperand(rsp, 0), input_reg); 3140 movsd(MemOperand(rsp, 0), input_reg);
3145 SlowTruncateToI(result_reg, rsp, 0); 3141 SlowTruncateToI(result_reg, rsp, 0);
3146 addq(rsp, Immediate(kDoubleSize)); 3142 addq(rsp, Immediate(kDoubleSize));
3147 3143
3148 bind(&done); 3144 bind(&done);
3149 } 3145 }
3150 3146
3151 3147
(...skipping 1835 matching lines...) Expand 10 before | Expand all | Expand 10 after
4987 imull(dividend); 4983 imull(dividend);
4988 if (divisor > 0 && ms.multiplier() < 0) addl(rdx, dividend); 4984 if (divisor > 0 && ms.multiplier() < 0) addl(rdx, dividend);
4989 if (divisor < 0 && ms.multiplier() > 0) subl(rdx, dividend); 4985 if (divisor < 0 && ms.multiplier() > 0) subl(rdx, dividend);
4990 if (ms.shift() > 0) sarl(rdx, Immediate(ms.shift())); 4986 if (ms.shift() > 0) sarl(rdx, Immediate(ms.shift()));
4991 } 4987 }
4992 4988
4993 4989
4994 } } // namespace v8::internal 4990 } } // namespace v8::internal
4995 4991
4996 #endif // V8_TARGET_ARCH_X64 4992 #endif // V8_TARGET_ARCH_X64
OLDNEW
« src/ia32/macro-assembler-ia32.cc ('K') | « src/x64/lithium-codegen-x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698