Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2020813002: Rewrite LoadExpectation to v1.0. (Closed)

Created:
4 years, 6 months ago by benjhayden
Modified:
4 years, 1 month ago
Reviewers:
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Base URL:
https://github.com/catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Rewrite LoadExpectation to v1.0. Currently, LoadExpectation encapsulates only Navigation to First Contentful Paint. There are lots of loading metrics that we want to write and support. They should all share code that is general enough to support them all. There are several fraught questions around what a general Loading abstraction should look like, which is why the current LoadExpectation is so simple that it is single-purpose. This new LoadExpectation effectively side-steps all of the fraught questions by making no claims and having no opinions. This new LoadExpectation is effectively a big bag of relevant events, with getters for common tasks like finding the first meaningful paint. https://docs.google.com/document/d/1WfsxAsoHg7iixDZz2ujAu9xf8tYzgAGttIoovmRFaog/edit

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+292 lines, -52 lines) Patch
M tracing/tracing/base/category_util.html View 1 chunk +6 lines, -1 line 0 comments Download
M tracing/tracing/extras/importer/trace_event_importer.html View 1 chunk +1 line, -0 lines 0 comments Download
M tracing/tracing/importer/find_load_expectations.html View 1 chunk +92 lines, -31 lines 0 comments Download
M tracing/tracing/model/instant_event.html View 1 chunk +1 line, -0 lines 0 comments Download
M tracing/tracing/model/user_model/load_expectation.html View 3 chunks +192 lines, -20 lines 0 comments Download

Messages

Total messages: 13 (13 generated)
benjhayden
Patchset #1 (id:1) has been deleted
4 years, 6 months ago (2016-06-01 17:45:55 UTC) #1
benjhayden
Patchset #1 (id:20001) has been deleted
4 years, 6 months ago (2016-06-01 17:45:59 UTC) #2
benjhayden
Patchset #1 (id:40001) has been deleted
4 years, 6 months ago (2016-06-01 17:46:03 UTC) #3
benjhayden
Patchset #1 (id:60001) has been deleted
4 years, 6 months ago (2016-06-01 17:46:06 UTC) #4
benjhayden
Patchset #1 (id:80001) has been deleted
4 years, 6 months ago (2016-06-01 17:47:27 UTC) #5
benjhayden
Description was changed from ========== LoadExpectation 1.0 ========== to ========== Rewrite LoadExpectation to v1.0. Currently, ...
4 years, 6 months ago (2016-06-01 17:55:19 UTC) #6
benjhayden
Patchset #1 (id:100001) has been deleted
4 years, 6 months ago (2016-06-01 22:56:41 UTC) #7
benjhayden
Patchset #1 (id:120001) has been deleted
4 years, 6 months ago (2016-06-01 22:56:44 UTC) #8
benjhayden
Patchset #1 (id:140001) has been deleted
4 years, 6 months ago (2016-06-01 22:56:47 UTC) #9
benjhayden
Patchset #1 (id:160001) has been deleted
4 years, 6 months ago (2016-06-01 23:01:17 UTC) #10
benjhayden
Patchset #1 (id:180001) has been deleted
4 years, 6 months ago (2016-06-01 23:01:21 UTC) #11
benjhayden
Description was changed from ========== Rewrite LoadExpectation to v1.0. Currently, LoadExpectation encapsulates only Navigation to ...
4 years, 6 months ago (2016-06-01 23:10:48 UTC) #12
benjhayden
4 years, 6 months ago (2016-06-01 23:14:33 UTC) #13
Patchset #1 (id:200001) has been deleted

Powered by Google App Engine
This is Rietveld 408576698