Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2020803002:
DevTools: [LiveSASS] property enabling/disabling should not add spaces (Closed)
|
Created:
4 years, 6 months ago by lushnikov Modified:
4 years, 5 months ago CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDevTools: [LiveSASS] property enabling/disabling should not add spaces
BUG=none
R=pfeldman
Committed: https://crrev.com/ac35a4f3096c0ee2c1983c10dd93df00d39b500a
Cr-Commit-Position: refs/heads/master@{#405147}
Patch Set 1 #
Total comments: 2
Patch Set 2 : address comment #
Messages
Total messages: 36 (16 generated)
please take a look
The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2020803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2020803002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
dgozman@chromium.org changed reviewers: + dgozman@chromium.org
lgtm https://codereview.chromium.org/2020803002/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/sass/SASSSupport.js (right): https://codereview.chromium.org/2020803002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/sass/SASSSupport.js:255: var endsWithSemicolon = propertyText.slice(2, -2).trim().endsWith(";"); No need to slice from the start?
What's the status of this?
https://codereview.chromium.org/2020803002/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/sass/SASSSupport.js (right): https://codereview.chromium.org/2020803002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/sass/SASSSupport.js:255: var endsWithSemicolon = propertyText.slice(2, -2).trim().endsWith(";"); On 2016/05/30 18:27:11, dgozman wrote: > No need to slice from the start? Done.
The CQ bit was checked by lushnikov@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org Link to the patchset: https://codereview.chromium.org/2020803002/#ps20001 (title: "address comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by lushnikov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by lushnikov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by lushnikov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
The CQ bit was checked by lushnikov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by lushnikov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== DevTools: [LiveSASS] property enabling/disabling should not add spaces BUG=none R=pfeldman ========== to ========== DevTools: [LiveSASS] property enabling/disabling should not add spaces BUG=none R=pfeldman Committed: https://crrev.com/ac35a4f3096c0ee2c1983c10dd93df00d39b500a Cr-Commit-Position: refs/heads/master@{#405147} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/ac35a4f3096c0ee2c1983c10dd93df00d39b500a Cr-Commit-Position: refs/heads/master@{#405147} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
