Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2020753002: Throw exception if curve is too short for setValueCurveAtTime (Closed)

Created:
4 years, 6 months ago by Raymond Toy
Modified:
4 years, 6 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews, haraken, hongchan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Throw exception if curve is too short for setValueCurveAtTime If the curve for setValueCurveAtTime is too short (length less than 2), an exception must be thrown. BUG=615477 TEST=audioparam-setValueCurve-exceptions.html updated Committed: https://crrev.com/0970fcf609bebf7792fcc9606983fad61e7da6a8 Cr-Commit-Position: refs/heads/master@{#397164}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/audioparam-setValueCurve-exceptions.html View 1 chunk +27 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/audioparam-setValueCurve-exceptions-expected.txt View 1 chunk +5 lines, -0 lines 2 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Raymond Toy
PTAL.
4 years, 6 months ago (2016-05-27 19:51:32 UTC) #2
Raymond Toy
On 2016/05/27 19:51:32, Raymond Toy wrote: > PTAL. Ping
4 years, 6 months ago (2016-05-31 21:40:26 UTC) #3
hongchan
lgtm https://codereview.chromium.org/2020753002/diff/1/third_party/WebKit/LayoutTests/webaudio/audioparam-setValueCurve-exceptions-expected.txt File third_party/WebKit/LayoutTests/webaudio/audioparam-setValueCurve-exceptions-expected.txt (right): https://codereview.chromium.org/2020753002/diff/1/third_party/WebKit/LayoutTests/webaudio/audioparam-setValueCurve-exceptions-expected.txt#newcode44 third_party/WebKit/LayoutTests/webaudio/audioparam-setValueCurve-exceptions-expected.txt:44: PASS setValueCurveAtTime([], 0, 0.01) threw InvalidStateError: Failed to ...
4 years, 6 months ago (2016-05-31 21:45:24 UTC) #4
Raymond Toy
https://codereview.chromium.org/2020753002/diff/1/third_party/WebKit/LayoutTests/webaudio/audioparam-setValueCurve-exceptions-expected.txt File third_party/WebKit/LayoutTests/webaudio/audioparam-setValueCurve-exceptions-expected.txt (right): https://codereview.chromium.org/2020753002/diff/1/third_party/WebKit/LayoutTests/webaudio/audioparam-setValueCurve-exceptions-expected.txt#newcode44 third_party/WebKit/LayoutTests/webaudio/audioparam-setValueCurve-exceptions-expected.txt:44: PASS setValueCurveAtTime([], 0, 0.01) threw InvalidStateError: Failed to execute ...
4 years, 6 months ago (2016-05-31 22:29:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2020753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2020753002/1
4 years, 6 months ago (2016-06-01 15:10:39 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 17:05:54 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 17:06:55 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0970fcf609bebf7792fcc9606983fad61e7da6a8
Cr-Commit-Position: refs/heads/master@{#397164}

Powered by Google App Engine
This is Rietveld 408576698