Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 2020743002: [heap] Add the free remainder of a black page to the free list. (Closed)

Created:
4 years, 6 months ago by ulan
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Add the free remainder of a black page to the free list. BUG=chromium:615489 Committed: https://crrev.com/8c6fedd653b2f1506feafd098e17316b86089b44 Cr-Commit-Position: refs/heads/master@{#36587}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : Rename test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -1 line) Patch
M src/heap/incremental-marking.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/mark-compact.cc View 1 2 2 chunks +10 lines, -1 line 0 comments Download
M src/heap/spaces.h View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 2 3 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
ulan
ptal
4 years, 6 months ago (2016-05-30 09:23:19 UTC) #4
Hannes Payer (out of office)
Cool, thanks for fixing! LGTM https://codereview.chromium.org/2020743002/diff/40001/test/cctest/heap/test-heap.cc File test/cctest/heap/test-heap.cc (right): https://codereview.chromium.org/2020743002/diff/40001/test/cctest/heap/test-heap.cc#newcode6769 test/cctest/heap/test-heap.cc:6769: TEST(MyTest) { I know, ...
4 years, 6 months ago (2016-05-30 11:27:10 UTC) #5
ulan
https://codereview.chromium.org/2020743002/diff/40001/test/cctest/heap/test-heap.cc File test/cctest/heap/test-heap.cc (right): https://codereview.chromium.org/2020743002/diff/40001/test/cctest/heap/test-heap.cc#newcode6769 test/cctest/heap/test-heap.cc:6769: TEST(MyTest) { On 2016/05/30 11:27:10, Hannes Payer wrote: > ...
4 years, 6 months ago (2016-05-30 12:41:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2020743002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2020743002/60001
4 years, 6 months ago (2016-05-30 12:41:23 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-05-30 13:09:34 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-05-30 13:10:18 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/8c6fedd653b2f1506feafd098e17316b86089b44
Cr-Commit-Position: refs/heads/master@{#36587}

Powered by Google App Engine
This is Rietveld 408576698