Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(827)

Issue 2020683002: Rewrite assignment operator on SkBitmap, fix asan (Closed)

Created:
4 years, 6 months ago by msarett
Modified:
4 years, 6 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 : #

Patch Set 2 : Remember all the fields #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -18 lines) Patch
M src/core/SkBitmap.cpp View 1 1 chunk +14 lines, -18 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2020683002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2020683002/40001
4 years, 6 months ago (2016-05-27 17:59:57 UTC) #6
msarett
4 years, 6 months ago (2016-05-27 18:00:16 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/8745)
4 years, 6 months ago (2016-05-27 18:09:39 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2020683002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2020683002/60001
4 years, 6 months ago (2016-05-27 18:12:18 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-27 18:29:50 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2020683002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2020683002/60001
4 years, 6 months ago (2016-05-27 18:31:03 UTC) #17
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 18:31:58 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://skia.googlesource.com/skia/+/0881fb545c7fe53d9572c22167458efdf9deece5

Powered by Google App Engine
This is Rietveld 408576698