Add package-config tests where test is running in Isolate.spawn-isolates.

Add package-config tests where test is running in Isolate.spawn-isolates.

R=floitsch@google.com

Committed: https://github.com/dart-lang/sdk/commit/f3f6d1e00da547acad377b5a08260dd51d16abb9

Committed: https://github.com/dart-lang/sdk/commit/eda2a81c0c8bada3b40b88a60cb5a463f3aaf3db

Committed: https://github.com/dart-lang/sdk/commit/0bd6b7e9244090ac72f458cb9b87b8684fd3df42

[Lasse Reichstein Nielsen, 2016-05-27 13:53:33]

lrn@google.com changed reviewers:
+ floitsch@google.com

[Lasse Reichstein Nielsen, 2016-05-27 13:53:34]

Work in progress. Will also add tests where spawning with spawnUri +
combinations.

[floitsch, 2016-05-27 14:26:50]

Lgtm

https://codereview.chromium.org/2020653002/diff/1/tests/standalone/packages_f...
File tests/standalone/packages_file_test.dart (right):

https://codereview.chromium.org/2020653002/diff/1/tests/standalone/packages_f...
tests/standalone/packages_file_test.dart:14: Future runTests(test) async {
Move that function out. Should make the diff better.

https://codereview.chromium.org/2020653002/diff/1/tests/standalone/packages_f...
tests/standalone/packages_file_test.dart:16: // It replaces "%file/" with URI of
the root directory of generated files and
Long line.

https://codereview.chromium.org/2020653002/diff/1/tests/standalone/packages_f...
tests/standalone/packages_file_test.dart:440: assert((checked = true));
Add a comment.

[Lasse Reichstein Nielsen, 2016-06-02 13:02:03]

PTAL

[floitsch, 2016-06-02 14:17:46]

LGTM.

https://codereview.chromium.org/2020653002/diff/40001/tests/standalone/packag...
File tests/standalone/packages_file_test.dart (right):

https://codereview.chromium.org/2020653002/diff/40001/tests/standalone/packag...
tests/standalone/packages_file_test.dart:67: // TEMPORARY FIX FOR ISSUE #26555
(http://dartbug.com/26555)
Somewhere you should have
"TODO(26555)"
this is the most common way of grepping for code that depends on an issue.

https://codereview.chromium.org/2020653002/diff/40001/tests/standalone/packag...
tests/standalone/packages_file_test.dart:139: String toPath(String string) {
new line before and after nested functions.

https://codereview.chromium.org/2020653002/diff/40001/tests/standalone/packag...
tests/standalone/packages_file_test.dart:200: /// has empty argument lists and
run the `main.dart` main file.
have

https://codereview.chromium.org/2020653002/diff/40001/tests/standalone/packag...
tests/standalone/packages_file_test.dart:607: //   bool search = conf.root ==
null && conf.config == null;
Why is this commented out?

[Lasse Reichstein Nielsen, 2016-06-03 11:54:24]

Description was changed from

==========
Add package-config tests where test is running in Isolate.spawn-isolates.
==========

to

==========
Add package-config tests where test is running in Isolate.spawn-isolates.

R=floitsch@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f3f6d1e00da547acad377b5a08260dd51d16abb9
==========

[Lasse Reichstein Nielsen, 2016-06-03 11:54:25]

Committed patchset #4 (id:60001) manually as
f3f6d1e00da547acad377b5a08260dd51d16abb9 (presubmit successful).

[Lasse Reichstein Nielsen, 2016-06-03 14:36:02]

Description was changed from

==========
Add package-config tests where test is running in Isolate.spawn-isolates.

R=floitsch@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f3f6d1e00da547acad377b5a08260dd51d16abb9
==========

to

==========
Add package-config tests where test is running in Isolate.spawn-isolates.

R=floitsch@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f3f6d1e00da547acad377b5a08260dd51d16abb9

Committed:
https://github.com/dart-lang/sdk/commit/eda2a81c0c8bada3b40b88a60cb5a463f3aaf3db
==========

[Lasse Reichstein Nielsen, 2016-06-03 14:36:05]

Committed patchset #6 (id:100001) manually as
eda2a81c0c8bada3b40b88a60cb5a463f3aaf3db (presubmit successful).

[Lasse Reichstein Nielsen, 2016-06-03 14:53:42]

Description was changed from

==========
Add package-config tests where test is running in Isolate.spawn-isolates.

R=floitsch@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f3f6d1e00da547acad377b5a08260dd51d16abb9

Committed:
https://github.com/dart-lang/sdk/commit/eda2a81c0c8bada3b40b88a60cb5a463f3aaf3db
==========

to

==========
Add package-config tests where test is running in Isolate.spawn-isolates.

R=floitsch@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f3f6d1e00da547acad377b5a08260dd51d16abb9

Committed:
https://github.com/dart-lang/sdk/commit/eda2a81c0c8bada3b40b88a60cb5a463f3aaf3db

Committed:
https://github.com/dart-lang/sdk/commit/0bd6b7e9244090ac72f458cb9b87b8684fd3df42
==========

[Lasse Reichstein Nielsen, 2016-06-03 14:53:44]

Committed patchset #7 (id:120001) manually as
0bd6b7e9244090ac72f458cb9b87b8684fd3df42 (presubmit successful).

[Lasse Reichstein Nielsen, 2016-06-06 11:36:32]

https://codereview.chromium.org/2020653002/diff/40001/tests/standalone/packag...
File tests/standalone/packages_file_test.dart (right):

https://codereview.chromium.org/2020653002/diff/40001/tests/standalone/packag...
tests/standalone/packages_file_test.dart:67: // TEMPORARY FIX FOR ISSUE #26555
(http://dartbug.com/26555)
On 2016/06/02 14:17:46, floitsch wrote:
> Somewhere you should have
> "TODO(26555)"
> this is the most common way of grepping for code that depends on an issue.

Done.

https://codereview.chromium.org/2020653002/diff/40001/tests/standalone/packag...
tests/standalone/packages_file_test.dart:139: String toPath(String string) {
On 2016/06/02 14:17:46, floitsch wrote:
> new line before and after nested functions.

Done.

https://codereview.chromium.org/2020653002/diff/40001/tests/standalone/packag...
tests/standalone/packages_file_test.dart:200: /// has empty argument lists and
run the `main.dart` main file.
On 2016/06/02 14:17:46, floitsch wrote:
> have

Done.

https://codereview.chromium.org/2020653002/diff/40001/tests/standalone/packag...
tests/standalone/packages_file_test.dart:607: //   bool search = conf.root ==
null && conf.config == null;
Ak, old code, no longer used. Neither is the one above, for that matter.
Removed.