|
|
Revert of Add FrameHost mojo service (patchset #23 id:490001 of https://codereview.chromium.org/1964273002/ )
Reason for revert:
Async request for zoom level doesn't work in all cases https://crbug.com/614348 https://crbug.com/613979.
I thought https://www.chromium.org/developers/design-documents/mojo/chrome-ipc-to-mojo-ipc-cheet-sheet#TOC-Threading-Model implied the ordering would be correct, but it seems that was too hopeful.
Original issue's description:
> Add FrameHost mojo service
>
> Adds new frame-level service with one initial method to handle host zoom
> level.
>
> This moves zoom level supply from async_resource_handler.cc to being a
> request made when render_frame_impl handles a willSendRequest.
>
> The goal of this change is to remove the dependency of
> content/browser/loader on the rest of content/browser in particular
> here, removing the use of c/b/host_zoom_map_impl.h in
> content/browser/loader/async_resource_handler.cc.
>
> BUG= 598073, 609607
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
>
> Committed: https://crrev.com/68c6f2ce16d9807b5cb82679099c82c40f39e911
> Cr-Commit-Position: refs/heads/master@{#394547}
TBR=dcheng@chromium.org,ben@chromium.org,jam@chromium.org,nasko@chromium.org,wjmaclean@chromium.org
BUG= 598073, 609607, 614348, 613979
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2007203002
Cr-Commit-Position: refs/heads/master@{#395761}
(cherry picked from commit 34ce95dd9c2ca3b90fc87169f1e4ed266e7bb94b)
Committed: https://chromium.googlesource.com/chromium/src/+/b43ea3087da4e351f0bf94481c9810738c3ae938
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+104 lines, -121 lines) |
Patch |
 |
M |
build/android/pylib/gtest/filter/content_browsertests_disabled
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
content/browser/frame_host/render_frame_host_impl.h
|
View
|
|
6 chunks |
+3 lines, -16 lines |
0 comments
|
Download
|
 |
M |
content/browser/frame_host/render_frame_host_impl.cc
|
View
|
|
6 chunks |
+0 lines, -29 lines |
0 comments
|
Download
|
 |
M |
content/browser/host_zoom_map_impl.h
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
content/browser/loader/DEPS
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
content/browser/loader/async_resource_handler.cc
|
View
|
|
2 chunks |
+16 lines, -0 lines |
0 comments
|
Download
|
 |
M |
content/browser/loader/async_revalidation_manager_unittest.cc
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
content/browser/loader/resource_dispatcher_host_unittest.cc
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
content/browser/loader/resource_message_filter.h
|
View
|
|
4 chunks |
+7 lines, -0 lines |
0 comments
|
Download
|
 |
M |
content/browser/loader/resource_message_filter.cc
|
View
|
|
4 chunks |
+9 lines, -0 lines |
0 comments
|
Download
|
 |
M |
content/browser/renderer_host/render_process_host_impl.cc
|
View
|
|
1 chunk |
+3 lines, -1 line |
0 comments
|
Download
|
 |
M |
content/common/BUILD.gn
|
View
|
|
2 chunks |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
D |
content/common/frame_host.mojom
|
View
|
|
1 chunk |
+0 lines, -11 lines |
0 comments
|
Download
|
 |
M |
content/common/view_messages.h
|
View
|
|
1 chunk |
+7 lines, -0 lines |
0 comments
|
Download
|
 |
M |
content/content_common_mojo_bindings.gyp
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
content/renderer/render_frame_impl.h
|
View
|
|
4 chunks |
+0 lines, -7 lines |
0 comments
|
Download
|
 |
M |
content/renderer/render_frame_impl.cc
|
View
|
|
5 chunks |
+4 lines, -26 lines |
0 comments
|
Download
|
 |
M |
content/renderer/render_frame_impl_browsertest.cc
|
View
|
|
2 chunks |
+0 lines, -27 lines |
0 comments
|
Download
|
 |
M |
content/renderer/render_view_browsertest.cc
|
View
|
|
1 chunk |
+26 lines, -0 lines |
0 comments
|
Download
|
 |
M |
content/renderer/render_view_impl.h
|
View
|
|
4 chunks |
+6 lines, -0 lines |
0 comments
|
Download
|
 |
M |
content/renderer/render_view_impl.cc
|
View
|
|
2 chunks |
+17 lines, -0 lines |
0 comments
|
Download
|
Total messages: 2 (1 generated)
|