Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: net/spdy/spdy_frame_builder_test.cc

Issue 202063002: Added OverwriteFlags method to SpdyFrameBuilder. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_frame_builder.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_frame_builder_test.cc
diff --git a/net/spdy/spdy_frame_builder_test.cc b/net/spdy/spdy_frame_builder_test.cc
index 28627bc5982373ed1d7f66245768fd2a61166733..ed565b0fdd98fd063dc53376d10444609f6b4c40 100644
--- a/net/spdy/spdy_frame_builder_test.cc
+++ b/net/spdy/spdy_frame_builder_test.cc
@@ -59,4 +59,22 @@ TEST_P(SpdyFrameBuilderTest, RewriteLength) {
base::StringPiece(built->data(), expected->size()));
}
+TEST_P(SpdyFrameBuilderTest, OverwriteFlags) {
+ // Create a HEADERS frame both via framer and manually via builder with
+ // different flags set, then make them match using OverwriteFlags().
+ SpdyFramer framer(spdy_version_);
+ if (spdy_version_ < SPDY4) {
+ return;
+ }
+ SpdyHeadersIR headers_ir(1);
+ headers_ir.set_end_headers(false);
+ scoped_ptr<SpdyFrame> expected(framer.SerializeHeaders(headers_ir));
+ SpdyFrameBuilder builder(expected->size());
+ builder.WriteFramePrefix(framer, HEADERS, HEADERS_FLAG_END_HEADERS, 1);
+ builder.OverwriteFlags(framer, 0);
+ scoped_ptr<SpdyFrame> built(builder.take());
+ EXPECT_EQ(base::StringPiece(expected->data(), expected->size()),
+ base::StringPiece(built->data(), built->size()));
+}
+
} // namespace net
« no previous file with comments | « net/spdy/spdy_frame_builder.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698