Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: ash/shell.h

Issue 2020623004: ash: Move shelf alignment and auto-hide calls from Shell to Shelf (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: typo Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/shell.h
diff --git a/ash/shell.h b/ash/shell.h
index 05901aa8c73953b506a6074d935b4c5e100b490e..b0e409b924354ddee39aecf4bfdf47fd1f2176d6 100644
--- a/ash/shell.h
+++ b/ash/shell.h
@@ -475,26 +475,15 @@ class ASH_EXPORT Shell : public SystemModalContainerEventFilterDelegate,
}
// Force the shelf to query for it's current visibility state.
+ // TODO(jamescook): Move to Shelf.
void UpdateShelfVisibility();
- // TODO(oshima): Define an interface to access shelf/launcher
- // state, or just use Launcher.
-
- // Sets/gets the shelf auto-hide behavior on |root_window|.
- void SetShelfAutoHideBehavior(ShelfAutoHideBehavior behavior,
- aura::Window* root_window);
- ShelfAutoHideBehavior GetShelfAutoHideBehavior(
- aura::Window* root_window) const;
-
- // Sets/gets shelf's alignment on |root_window|.
- void SetShelfAlignment(wm::ShelfAlignment alignment,
- aura::Window* root_window);
- wm::ShelfAlignment GetShelfAlignment(const aura::Window* root_window) const;
-
// Called when the alignment for a shelf changes.
+ // TODO(jamescook): Move to Shelf.
void OnShelfAlignmentChanged(aura::Window* root_window);
// Called when the auto-hide behavior for a shelf changes.
+ // TODO(jamescook): Move to Shelf.
void OnShelfAutoHideBehaviorChanged(aura::Window* root_window);
// Notifies |observers_| when entering or exiting fullscreen mode in

Powered by Google App Engine
This is Rietveld 408576698