ash: Move shelf alignment and auto-hide calls from Shell to Shelf

ash: Move shelf alignment and auto-hide calls from Shell to Shelf

Shelf (aka ShelfController) should be the single point of access for alignment
and auto-hide state.

* Eliminate Shell::GetShelfAlignment and SetShelfAlignment
* Eliminate Shell::GetShelfAutoHideBehavior and SetShelfAutoHideBehavior
* Convert Shelf::GetAutoHideBehavior() to auto_hide_behavior()
* Use Shelf::ForPrimaryDisplay() in unit tests to avoid accessing the
  RootWindowController.

BUG=615502
TEST=existing ash_unittests and unit_tests

Committed: https://crrev.com/6afad6dbdc55b439182cadbd9cd08efd3f7ae6ee
Cr-Commit-Position: refs/heads/master@{#396994}

[James Cook, 2016-05-27 22:04:34]

Description was changed from

==========
ash: Move shelf alignment and auto-hide calls from Shell to Shelf

Shelf (aka ShelfController) should be the single point of access for alignment
and auto-hide state.

* Eliminate Shell::GetShelfAlignment and SetShelfAlignment
* Eliminate Shell::GetShelfAutoHideBehavior and SetShelfAutoHideBehavior
* Use Shelf::ForPrimaryDisplay() in unit tests to avoid accessing the
  RootWindowController.

BUG=615502
TEST=existing ash_unittests and unit_tests
==========

to

==========
ash: Move shelf alignment and auto-hide calls from Shell to Shelf

Shelf (aka ShelfController) should be the single point of access for alignment
and auto-hide state.

* Eliminate Shell::GetShelfAlignment and SetShelfAlignment
* Eliminate Shell::GetShelfAutoHideBehavior and SetShelfAutoHideBehavior
* Convert Shelf::GetAutoHideBehavior() to auto_hide_behavior()
* Use Shelf::ForPrimaryDisplay() in unit tests to avoid accessing the
  RootWindowController.

BUG=615502
TEST=existing ash_unittests and unit_tests
==========

[James Cook, 2016-05-27 22:17:47]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org

[James Cook, 2016-05-27 22:17:47]

msw, please take a look.

This is a mostly mechanical change to clean up some TODOs and add others.

[msw, 2016-05-27 22:36:41]

lgtm with minor nits.

https://codereview.chromium.org/2020623004/diff/20001/ash/mus/context_menu_mu...
File ash/mus/context_menu_mus.cc (right):

https://codereview.chromium.org/2020623004/diff/20001/ash/mus/context_menu_mu...
ash/mus/context_menu_mus.cc:51: SHELF_AUTO_HIDE_BEHAVIOR_ALWAYS
nit: git cl format? (not your CL's fault if wrong)

https://codereview.chromium.org/2020623004/diff/20001/ash/wm/dock/docked_wind...
File ash/wm/dock/docked_window_resizer_unittest.cc (right):

https://codereview.chromium.org/2020623004/diff/20001/ash/wm/dock/docked_wind...
ash/wm/dock/docked_window_resizer_unittest.cc:616: // set launcher shelf to be
aligned on the right
nit: remove/update incorrect comment?

https://codereview.chromium.org/2020623004/diff/20001/chrome/browser/ui/ash/l...
File chrome/browser/ui/ash/launcher/launcher_context_menu.cc (right):

https://codereview.chromium.org/2020623004/diff/20001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/launcher_context_menu.cc:85: if (command_id ==
MENU_AUTO_HIDE) {
nit: remove curlies

[James Cook, 2016-05-27 22:56:25]

jamescook@chromium.org changed reviewers:
+ oshima@chromium.org

[James Cook, 2016-05-27 22:56:26]

oshima, can I get OWNERS?

https://codereview.chromium.org/2020623004/diff/20001/ash/mus/context_menu_mu...
File ash/mus/context_menu_mus.cc (right):

https://codereview.chromium.org/2020623004/diff/20001/ash/mus/context_menu_mu...
ash/mus/context_menu_mus.cc:51: SHELF_AUTO_HIDE_BEHAVIOR_ALWAYS
On 2016/05/27 22:36:40, msw wrote:
> nit: git cl format? (not your CL's fault if wrong)

This is the output of git cl format. :-(

https://codereview.chromium.org/2020623004/diff/20001/ash/wm/dock/docked_wind...
File ash/wm/dock/docked_window_resizer_unittest.cc (right):

https://codereview.chromium.org/2020623004/diff/20001/ash/wm/dock/docked_wind...
ash/wm/dock/docked_window_resizer_unittest.cc:616: // set launcher shelf to be
aligned on the right
On 2016/05/27 22:36:41, msw wrote:
> nit: remove/update incorrect comment?

Updated.

[James Cook, 2016-05-31 01:37:18]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-31 01:37:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2020623004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2020623004/60001

[commit-bot: I haz the power, 2016-05-31 02:30:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-31 02:30:08]

Dry run: This issue passed the CQ dry run.

[James Cook, 2016-05-31 21:25:35]

Ping oshima (for OWNERS)?

[oshima, 2016-05-31 21:29:36]

lgtm

[James Cook, 2016-05-31 22:16:27]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-05-31 22:16:27]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org,
oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/2020623004/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2016-05-31 22:17:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2020623004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2020623004/80001

[commit-bot: I haz the power, 2016-06-01 00:35:12]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-06-01 00:37:18]

Description was changed from

==========
ash: Move shelf alignment and auto-hide calls from Shell to Shelf

Shelf (aka ShelfController) should be the single point of access for alignment
and auto-hide state.

* Eliminate Shell::GetShelfAlignment and SetShelfAlignment
* Eliminate Shell::GetShelfAutoHideBehavior and SetShelfAutoHideBehavior
* Convert Shelf::GetAutoHideBehavior() to auto_hide_behavior()
* Use Shelf::ForPrimaryDisplay() in unit tests to avoid accessing the
  RootWindowController.

BUG=615502
TEST=existing ash_unittests and unit_tests
==========

to

==========
ash: Move shelf alignment and auto-hide calls from Shell to Shelf

Shelf (aka ShelfController) should be the single point of access for alignment
and auto-hide state.

* Eliminate Shell::GetShelfAlignment and SetShelfAlignment
* Eliminate Shell::GetShelfAutoHideBehavior and SetShelfAutoHideBehavior
* Convert Shelf::GetAutoHideBehavior() to auto_hide_behavior()
* Use Shelf::ForPrimaryDisplay() in unit tests to avoid accessing the
  RootWindowController.

BUG=615502
TEST=existing ash_unittests and unit_tests

Committed: https://crrev.com/6afad6dbdc55b439182cadbd9cd08efd3f7ae6ee
Cr-Commit-Position: refs/heads/master@{#396994}
==========

[commit-bot: I haz the power, 2016-06-01 00:37:19]

Patchset 5 (id:??) landed as
https://crrev.com/6afad6dbdc55b439182cadbd9cd08efd3f7ae6ee
Cr-Commit-Position: refs/heads/master@{#396994}