Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 202059: Add a --check flag. This causes gyp to check syntax of files more carefully,... (Closed)

Created:
10 years, 5 months ago by Ben Laurie (Chromium)
Modified:
8 years, 9 months ago
CC:
gyp-developer_googlegroups.com, Nico
Visibility:
Public.

Description

Add a --check flag. This causes gyp to check syntax of files more carefully, but makes it about 50% slower, so defaults to off.

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 8

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -19 lines) Patch
M pylib/gyp/__init__.py View 1 2 4 chunks +5 lines, -3 lines 0 comments Download
M pylib/gyp/input.py View 1 2 3 10 chunks +72 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Ben Laurie (Chromium)
On Thu, Sep 10, 2009 at 12:16 AM, Ben Laurie<benl@chromium.org> wrote: > On Tue, Sep ...
10 years, 5 months ago (2009-09-11 15:43:34 UTC) #1
Ben Laurie (Chromium)
Did anyone notice this?
10 years, 5 months ago (2009-09-12 09:49:27 UTC) #2
M-A Ruel
Can you get numbers w.r.t. load time incurred by import compiler? I don't know, maybe ...
10 years, 5 months ago (2009-09-18 13:04:55 UTC) #3
Ben Laurie (Chromium)
http://codereview.chromium.org/202059/diff/4001/4002 File pylib/gyp/__init__.py (right): http://codereview.chromium.org/202059/diff/4001/4002#newcode33 Line 33: includes=[], depth='.', params={}, check=False): On 2009/09/18 13:04:55, Marc-Antoine ...
10 years, 5 months ago (2009-09-18 13:17:32 UTC) #4
M-A Ruel
http://codereview.chromium.org/202059/diff/4001/4003 File pylib/gyp/input.py (right): http://codereview.chromium.org/202059/diff/4001/4003#newcode119 Line 119: def CheckedEval(file_contents): Add a description about what it ...
10 years, 5 months ago (2009-09-18 13:21:07 UTC) #5
Ben Laurie (Chromium)
http://codereview.chromium.org/202059/diff/4001/4003 File pylib/gyp/input.py (right): http://codereview.chromium.org/202059/diff/4001/4003#newcode119 Line 119: def CheckedEval(file_contents): On 2009/09/18 13:21:07, Marc-Antoine Ruel wrote: ...
10 years, 5 months ago (2009-09-18 14:03:27 UTC) #6
Mark Mentovai
10 years, 5 months ago (2009-09-19 18:01:18 UTC) #7
OK, I checked this in along with updated test expectations where it count at
lucky r666.  Thanks for the patch.

Powered by Google App Engine
This is Rietveld 408576698