Issue 202056: Make themes in the incognito NTP which are bottom-aligned attach to the botto...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 202056: Make themes in the incognito NTP which are bottom-aligned attach to the botto... (Closed)

Created:
11 years, 3 months ago by Miranda Callahan

Modified:
9 years, 7 months ago

Reviewers:
arv (Not doing code reviews)

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make themes in the incognito NTP which are bottom-aligned attach to the bottom of the screen, rather than the bottom of the text box. BUG= http://crbug.com/21543 TEST= Install "Folders" theme. Open incognito window. Observe that NTP background looks the same as it doesn in normal mode. [Change entirely arv's work.] Committed as http://src.chromium.org/viewvc/chrome?view=rev&revision=25961

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -7 lines)			Patch
	M	chrome/browser/resources/new_incognito_tab_theme.css	View		1 chunk	+9 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages