Hook up TABLET_MODE switch to maximize_mode_controller

ash/wm/maximize_mode/maximize_mode_controller_unittest.cc

Index: ash/wm/maximize_mode/maximize_mode_controller_unittest.cc
diff --git a/ash/wm/maximize_mode/maximize_mode_controller_unittest.cc b/ash/wm/maximize_mode/maximize_mode_controller_unittest.cc
index 251885b7212fc2907158ccc625f6a02efdc56235..a09c707587cb57377d2f658ebf40b20ea2ec7ec8 100644
--- a/ash/wm/maximize_mode/maximize_mode_controller_unittest.cc
+++ b/ash/wm/maximize_mode/maximize_mode_controller_unittest.cc
@@ -155,6 +155,15 @@ class MaximizeModeControllerTest : public test::AshTestBase {
     return maximize_mode_controller()->WasLidOpenedRecently();
   }
 
+  void ToggleTabletMode(const bool on) {

[Daniel Erat, 2016/06/06 17:23:08]

nit: rename this to SetTabletMode (toggling would just reverse the current
state) and remove "const" from param

[jcliang, 2016/06/06 18:19:25]

Done.

+    maximize_mode_controller()->TabletModeEventReceived(
+        on, maximize_mode_controller()->tick_clock_->NowTicks());
+  }
+
+  bool IsTabletModeOn() {

[Daniel Erat, 2016/06/06 17:23:08]

i'd delete this method and the calls to it. checking the class's internal
members doesn't seem useful and makes it hard to change the class later; you
really just want to check that it's setting maximized mode correctly (which
you're already doing).

[jcliang, 2016/06/06 18:19:25]

Done.

+    return maximize_mode_controller()->tablet_mode_switch_is_on_;
+  }
+
   bool AreEventsBlocked() {
     return !!maximize_mode_controller()->event_blocker_.get();
   }
@@ -266,6 +275,30 @@ TEST_F(MaximizeModeControllerTest, WasLidOpenedRecentlyOverTime) {
   EXPECT_FALSE(WasLidOpenedRecently());
 }
 
+TEST_F(MaximizeModeControllerTest, TabletModeTransition) {
+  ASSERT_FALSE(IsTabletModeOn());
+
+  OpenLidToAngle(90.0f);
+  EXPECT_FALSE(IsMaximizeModeStarted());
+
+  OpenLidToAngle(355.0f);
+  EXPECT_FALSE(IsMaximizeModeStarted());

[Daniel Erat, 2016/06/06 17:23:07]

why didn't this trigger maximize mode? it is because not enough time had passed?

[jcliang, 2016/06/06 18:19:25]

I meant to trigger an unstable reading and make sure the state doesn't change.
I've added a HoldDeviceVertical() to make the intent clear.

+
+  ToggleTabletMode(true);
+  EXPECT_TRUE(IsTabletModeOn());
+  EXPECT_TRUE(IsMaximizeModeStarted());
+
+  ToggleTabletMode(false);
+  EXPECT_FALSE(IsTabletModeOn());
+  EXPECT_TRUE(IsMaximizeModeStarted());
+
+  OpenLidToAngle(300.0f);
+  EXPECT_TRUE(IsMaximizeModeStarted());
+
+  OpenLidToAngle(90.0f);
+  EXPECT_FALSE(IsMaximizeModeStarted());
+}

[Daniel Erat, 2016/06/06 17:23:07]

can you open the lid to a large angle at the end of this test while the switch
is off (after advancing time, if necessary) to make sure that that still
triggers maximize mode?

[jcliang, 2016/06/06 18:19:25]

Done.

+
 // Verify the maximize mode enter/exit thresholds for stable angles.
 TEST_F(MaximizeModeControllerTest, StableHingeAnglesWithLidOpened) {
   ASSERT_FALSE(IsMaximizeModeStarted());