Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2020513003: Prevent augmentRepeatInterval from computing a negative delay (Closed)

Created:
4 years, 6 months ago by alex clarke (OOO till 29th)
Modified:
4 years, 6 months ago
Reviewers:
Ian Vollick, Sami
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prevent augmentRepeatInterval from computing a negative delay Under some circumstances augmentRepeatInterval could compute a negative delay. Prevent this by clamping the result. BUG=615270 Committed: https://crrev.com/e7273e13e246f8de550a4684026707232ffdf4a4 Cr-Commit-Position: refs/heads/master@{#396475}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M third_party/WebKit/Source/platform/Timer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/TimerTest.cpp View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
alex clarke (OOO till 29th)
4 years, 6 months ago (2016-05-27 13:13:17 UTC) #2
alex clarke (OOO till 29th)
PTAL :)
4 years, 6 months ago (2016-05-27 13:18:51 UTC) #4
Sami
lgtm (probably meant me instead of samiv@ensisoft.com :)
4 years, 6 months ago (2016-05-27 13:44:28 UTC) #6
alex clarke (OOO till 29th)
Oops yes I did :( +Ian for OWNERS review.
4 years, 6 months ago (2016-05-27 13:45:58 UTC) #8
Ian Vollick
On 2016/05/27 13:45:58, alex clarke wrote: > Oops yes I did :( > > +Ian ...
4 years, 6 months ago (2016-05-27 13:48:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2020513003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2020513003/1
4 years, 6 months ago (2016-05-27 13:49:48 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-27 15:49:24 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 15:50:55 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e7273e13e246f8de550a4684026707232ffdf4a4
Cr-Commit-Position: refs/heads/master@{#396475}

Powered by Google App Engine
This is Rietveld 408576698