Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2020493002: Create a LayerDelegate for recreated layers to draw when their content is invalidated. (Closed)

Created:
4 years, 6 months ago by oshima
Modified:
4 years, 6 months ago
Reviewers:
sadrul
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, tfarina, jam, dcheng, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, shuchen+watch_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Create a LayerDelegate for recreated layers to draw when their content is invalidated. This is to mitigate the issue where the content of the layer has to be redrawn while dragging a window in another display. This can draw the display items recorded for different device scale factor which can have artifacts, but it's better than empty layer. The same issue can happen during hiding/showing animation in theory, but I'm leaving them as is because that's very rare and most likely not noticeable. BUG=604868 TEST=WindowUtilTest.RecreateLayersWithDelegate TBR=sadrul@chromium.org Review-Url: https://codereview.chromium.org/1992853002 Cr-Commit-Position: refs/heads/master@{#394993} (cherry picked from commit e1dbe8e0ce560e5e2979e44b39268ac24bc3fc25) Committed: https://chromium.googlesource.com/chromium/src/+/c81fdc9edfb72dd0826075e2f77478f53577aea8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+263 lines, -22 lines) Patch
M ash/rotator/screen_rotation_animator.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/aura/wm_window_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/drag_window_controller.h View 2 chunks +8 lines, -2 lines 0 comments Download
M ash/wm/drag_window_controller.cc View 7 chunks +88 lines, -6 lines 0 comments Download
M ash/wm/drag_window_resizer_unittest.cc View 4 chunks +37 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/contents_web_view.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/view_unittest_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/wm/core/window_animations.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/wm/core/window_util.h View 2 chunks +18 lines, -1 line 0 comments Download
M ui/wm/core/window_util.cc View 3 chunks +17 lines, -5 lines 0 comments Download
M ui/wm/core/window_util_unittest.cc View 3 chunks +87 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
oshima
4 years, 6 months ago (2016-05-27 00:21:25 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c81fdc9edfb72dd0826075e2f77478f53577aea8.

Powered by Google App Engine
This is Rietveld 408576698