Issue 2020483002: clean up API for file_generator.dart

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2020483002: clean up API for file_generator.dart (Closed)

Created:
4 years, 7 months ago by skybrian

Modified:
4 years, 6 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dart-protoc-plugin.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+51 lines, -80 lines)			Patch
M	lib/code_generator.dart	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	lib/file_generator.dart	View	10 chunks	+39 lines, -42 lines	0 comments	Download
M	test/file_generator_test.dart	View	9 chunks	+11 lines, -35 lines	0 comments	Download

Dependent Patchsets:

Total messages: 5 (2 generated)

skybrian

4 years, 6 months ago (2016-05-27 18:14:21 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e93df92a5aa08abbc3fde63b9cc1b7d150ff644f (presubmit successful).