Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Side by Side Diff: gpu/command_buffer/service/framebuffer_manager.h

Issue 2020473002: Check layer is valid for framebuffer 3D texture attachments. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef GPU_COMMAND_BUFFER_SERVICE_FRAMEBUFFER_MANAGER_H_ 5 #ifndef GPU_COMMAND_BUFFER_SERVICE_FRAMEBUFFER_MANAGER_H_
6 #define GPU_COMMAND_BUFFER_SERVICE_FRAMEBUFFER_MANAGER_H_ 6 #define GPU_COMMAND_BUFFER_SERVICE_FRAMEBUFFER_MANAGER_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 RenderbufferManager* renderbuffer_manager, 46 RenderbufferManager* renderbuffer_manager,
47 TextureManager* texture_manager, 47 TextureManager* texture_manager,
48 bool cleared) = 0; 48 bool cleared) = 0;
49 virtual bool IsPartiallyCleared() const = 0; 49 virtual bool IsPartiallyCleared() const = 0;
50 virtual bool IsTextureAttachment() const = 0; 50 virtual bool IsTextureAttachment() const = 0;
51 virtual bool IsRenderbufferAttachment() const = 0; 51 virtual bool IsRenderbufferAttachment() const = 0;
52 virtual bool IsTexture(TextureRef* texture) const = 0; 52 virtual bool IsTexture(TextureRef* texture) const = 0;
53 virtual bool IsRenderbuffer( 53 virtual bool IsRenderbuffer(
54 Renderbuffer* renderbuffer) const = 0; 54 Renderbuffer* renderbuffer) const = 0;
55 virtual bool Is3D() const = 0; 55 virtual bool Is3D() const = 0;
56
57 // If it's a 3D texture attachment, return true if
58 // FRAMEBUFFER_ATTACHMENT_TEXTURE_LAYER is smaller than the number of
59 // layers in the texture.
60 virtual bool IsLayerValid() const = 0;
61
56 virtual bool CanRenderTo(const FeatureInfo* feature_info) const = 0; 62 virtual bool CanRenderTo(const FeatureInfo* feature_info) const = 0;
57 virtual void DetachFromFramebuffer(Framebuffer* framebuffer) const = 0; 63 virtual void DetachFromFramebuffer(Framebuffer* framebuffer) const = 0;
58 virtual bool ValidForAttachmentType(GLenum attachment_type, 64 virtual bool ValidForAttachmentType(GLenum attachment_type,
59 ContextType context_type, 65 ContextType context_type,
60 uint32_t max_color_attachments) = 0; 66 uint32_t max_color_attachments) = 0;
61 virtual size_t GetSignatureSize(TextureManager* texture_manager) const = 0; 67 virtual size_t GetSignatureSize(TextureManager* texture_manager) const = 0;
62 virtual void AddToSignature( 68 virtual void AddToSignature(
63 TextureManager* texture_manager, std::string* signature) const = 0; 69 TextureManager* texture_manager, std::string* signature) const = 0;
64 virtual bool FormsFeedbackLoop(TextureRef* texture, GLint level) const = 0; 70 virtual bool FormsFeedbackLoop(TextureRef* texture, GLint level) const = 0;
65 virtual bool EmulatingRGB() const = 0; 71 virtual bool EmulatingRGB() const = 0;
(...skipping 254 matching lines...) Expand 10 before | Expand all | Expand 10 after
320 326
321 scoped_refptr<FramebufferCompletenessCache> framebuffer_combo_complete_cache_; 327 scoped_refptr<FramebufferCompletenessCache> framebuffer_combo_complete_cache_;
322 328
323 DISALLOW_COPY_AND_ASSIGN(FramebufferManager); 329 DISALLOW_COPY_AND_ASSIGN(FramebufferManager);
324 }; 330 };
325 331
326 } // namespace gles2 332 } // namespace gles2
327 } // namespace gpu 333 } // namespace gpu
328 334
329 #endif // GPU_COMMAND_BUFFER_SERVICE_FRAMEBUFFER_MANAGER_H_ 335 #endif // GPU_COMMAND_BUFFER_SERVICE_FRAMEBUFFER_MANAGER_H_
OLDNEW
« no previous file with comments | « no previous file | gpu/command_buffer/service/framebuffer_manager.cc » ('j') | gpu/command_buffer/service/framebuffer_manager.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698