Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1460)

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

Issue 2020453002: [Mac][Material Design] Adjust location of Import Bookmarks textfield. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
index b3bde6358e7e88b6778823967fb3ea27fcc2a9b5..6738897b58240ad4739a9597436f5ef6ebd96e99 100644
--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
@@ -502,21 +502,13 @@ CGFloat BookmarkRightMargin() {
originalNoItemsRect_ = [[buttonView_ noItemTextfield] frame];
originalImportBookmarksRect_ = [[buttonView_ importBookmarksButton] frame];
if (isModeMaterial) {
- // Bookmark buttons are shorter and start farther from the bookmark bar's
- // left edge so adjust the positions of the noItems and importBookmarks
- // textfields.
+ // Bookmark buttons start farther from the bookmark bar's left edge so
+ // adjust the positions of the noItems and importBookmarks textfields.
const CGFloat kMaterialBookmarksTextfieldOffsetX = 14;
- const CGFloat kMaterialBookmarksTextfieldOffsetY = -2;
- originalNoItemsRect_.origin =
- NSOffsetRect(originalNoItemsRect_,
- kMaterialBookmarksTextfieldOffsetX,
- kMaterialBookmarksTextfieldOffsetY).origin;
+ originalNoItemsRect_.origin.x += kMaterialBookmarksTextfieldOffsetX;
[[buttonView_ noItemTextfield] setFrame:originalNoItemsRect_];
- originalImportBookmarksRect_.origin =
- NSOffsetRect(originalImportBookmarksRect_,
- kMaterialBookmarksTextfieldOffsetX,
- kMaterialBookmarksTextfieldOffsetY).origin;
+ originalImportBookmarksRect_.origin.x += kMaterialBookmarksTextfieldOffsetX;
[[buttonView_ importBookmarksButton] setFrame:originalImportBookmarksRect_];
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698