Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issue 202043002: DevTools: Use open resource dialog for go to line feature in sources panel. (Closed)

Created:
6 years, 9 months ago by vsevik
Modified:
6 years, 9 months ago
Reviewers:
lushnikov, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: Use open resource dialog for go to line feature in sources panel. R=lushnikov@chromium.org, lushnikov, pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169530

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Fixed outline dialog #

Patch Set 4 : Rebaselined #

Patch Set 5 : Rebaselined #

Patch Set 6 : Removed old go to line dialog shortcut #

Patch Set 7 : Rebaselined #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -48 lines) Patch
M LayoutTests/inspector/jump-to-previous-editing-location.html View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/FilteredItemSelectionDialog.js View 3 chunks +15 lines, -9 lines 0 comments Download
M Source/devtools/front_end/GoToLineDialog.js View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/devtools/front_end/ShortcutsScreen.js View 2 chunks +5 lines, -0 lines 0 comments Download
M Source/devtools/front_end/SourcesPanel.js View 1 2 3 4 5 5 chunks +23 lines, -36 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
vsevik
PTAL
6 years, 9 months ago (2014-03-17 16:15:10 UTC) #1
lushnikov
lgtm
6 years, 9 months ago (2014-03-18 09:29:36 UTC) #2
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 9 months ago (2014-03-18 09:29:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/202043002/40001
6 years, 9 months ago (2014-03-18 09:30:06 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-18 09:31:12 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_compile_dbg
6 years, 9 months ago (2014-03-18 09:31:12 UTC) #6
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 9 months ago (2014-03-18 11:09:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/202043002/60001
6 years, 9 months ago (2014-03-18 11:09:58 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-18 11:13:46 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 9 months ago (2014-03-18 11:13:48 UTC) #10
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 9 months ago (2014-03-18 13:33:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/202043002/80001
6 years, 9 months ago (2014-03-18 13:33:27 UTC) #12
vsevik
The CQ bit was unchecked by vsevik@chromium.org
6 years, 9 months ago (2014-03-18 15:42:04 UTC) #13
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 9 months ago (2014-03-18 16:58:47 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/202043002/100001
6 years, 9 months ago (2014-03-18 16:59:03 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-18 17:32:06 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 9 months ago (2014-03-18 17:32:09 UTC) #17
vsevik
6 years, 9 months ago (2014-03-19 08:51:33 UTC) #18
Message was sent while issue was closed.
Committed patchset #7 manually as r169530 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698