Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4567)

Unified Diff: chrome/common/variations/child_process_field_trial_syncer.h

Issue 2020413002: Refactor out a new class for syncing field trials in child processes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_common.gypi ('k') | chrome/common/variations/child_process_field_trial_syncer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/variations/child_process_field_trial_syncer.h
diff --git a/chrome/common/variations/child_process_field_trial_syncer.h b/chrome/common/variations/child_process_field_trial_syncer.h
new file mode 100644
index 0000000000000000000000000000000000000000..404dcb3fd02fb0916639bc744f3a979081ed34c6
--- /dev/null
+++ b/chrome/common/variations/child_process_field_trial_syncer.h
@@ -0,0 +1,54 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_COMMON_VARIATIONS_CHILD_PROCESS_FIELD_TRIAL_SYNCER_H_
+#define CHROME_COMMON_VARIATIONS_CHILD_PROCESS_FIELD_TRIAL_SYNCER_H_
+
+#include <string>
+
+#include "base/macros.h"
+#include "base/metrics/field_trial.h"
+#include "ipc/ipc_sender.h"
+
+namespace base {
+class CommandLine;
+}
+
+namespace chrome_variations {
+
+// ChildProcessFieldTrialSyncer is a utility class that's responsible for
+// syncing the "activated" state of field trials between browser and child
+// processes. Specifically, when a field trial is activated in the browser, it
+// also activates it in the child process and when a field trial is activated
+// in the child process, it notifies the browser process to activate it.
+class ChildProcessFieldTrialSyncer : public base::FieldTrialList::Observer {
+ public:
+ // ChildProcessFieldTrialSyncer constructor taking an externally owned
+ // |ipc_sender| param for sending ChromeViewHostMsg_FieldTrialActivated IPCs
+ // to the browser process. The |ipc_sender| must outlive this object.
+ explicit ChildProcessFieldTrialSyncer(IPC::Sender* ipc_sender);
+ ~ChildProcessFieldTrialSyncer() override;
+
+ // Initializes field trial state change observation and notifies the browser
+ // of any field trials that might have already been activated.
+ void InitFieldTrialObserving(const base::CommandLine& command_line);
+
+ // Handler for messages from the browser process notifying the child process
+ // that a field trial was activated.
+ void OnSetFieldTrialGroup(const std::string& trial_name,
+ const std::string& group_name);
+
+ private:
+ // base::FieldTrialList::Observer:
rkaplow 2016/06/01 21:08:38 ?
Alexei Svitkine (slow) 2016/06/01 21:13:58 That's the comment syntax to indicate that the met
rkaplow 2016/06/01 21:16:06 Acknowledged.
+ void OnFieldTrialGroupFinalized(const std::string& trial_name,
+ const std::string& group_name) override;
+
+ IPC::Sender* const ipc_sender_;
+
+ DISALLOW_COPY_AND_ASSIGN(ChildProcessFieldTrialSyncer);
+};
+
+} // namespace chrome_variations
+
+#endif // CHROME_COMMON_VARIATIONS_CHILD_PROCESS_FIELD_TRIAL_SYNCER_H_
« no previous file with comments | « chrome/chrome_common.gypi ('k') | chrome/common/variations/child_process_field_trial_syncer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698