Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 20204005: Make standalone D8 trace to single hydrogen.cfg file. (Closed)

Created:
7 years, 5 months ago by Michael Starzinger
Modified:
7 years, 5 months ago
Reviewers:
titzer
CC:
v8-dev
Visibility:
Public.

Description

Make standalone D8 trace to single hydrogen.cfg file. R=titzer@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=15882

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addessed comments by Ben Titzer. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -8 lines) Patch
M src/d8.cc View 1 2 chunks +6 lines, -4 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/hydrogen.h View 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Starzinger
7 years, 5 months ago (2013-07-25 13:46:42 UTC) #1
titzer
lgtm https://codereview.chromium.org/20204005/diff/1/src/d8.cc File src/d8.cc (right): https://codereview.chromium.org/20204005/diff/1/src/d8.cc#newcode1555 src/d8.cc:1555: fake_argv[1] = strdup("--trace-hydrogen-file=hydrogen.cfg"); do you mean argv[2]?
7 years, 5 months ago (2013-07-25 14:00:33 UTC) #2
Michael Starzinger
https://codereview.chromium.org/20204005/diff/1/src/d8.cc File src/d8.cc (right): https://codereview.chromium.org/20204005/diff/1/src/d8.cc#newcode1555 src/d8.cc:1555: fake_argv[1] = strdup("--trace-hydrogen-file=hydrogen.cfg"); On 2013/07/25 14:00:34, titzer wrote: > ...
7 years, 5 months ago (2013-07-25 14:11:31 UTC) #3
Michael Starzinger
7 years, 5 months ago (2013-07-25 14:11:59 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r15882 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698