Issue 20204005: Make standalone D8 trace to single hydrogen.cfg file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20204005: Make standalone D8 trace to single hydrogen.cfg file. (Closed)

Created:
7 years, 5 months ago by Michael Starzinger

Modified:
7 years, 5 months ago

Reviewers:
titzer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Make standalone D8 trace to single hydrogen.cfg file. R=titzer@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=15882

Patch Set 2 : Addessed comments by Ben Titzer. #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -8 lines)			Patch
M	src/d8.cc	View	1	2 chunks	+6 lines, -4 lines	0 comments	Download
M	src/flag-definitions.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/hydrogen.h	View		1 chunk	+8 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

titzer

lgtm https://codereview.chromium.org/20204005/diff/1/src/d8.cc File src/d8.cc (right): https://codereview.chromium.org/20204005/diff/1/src/d8.cc#newcode1555 src/d8.cc:1555: fake_argv[1] = strdup("--trace-hydrogen-file=hydrogen.cfg"); do you mean argv[2]?

7 years, 5 months ago (2013-07-25 14:00:33 UTC) #2

Michael Starzinger

https://codereview.chromium.org/20204005/diff/1/src/d8.cc File src/d8.cc (right): https://codereview.chromium.org/20204005/diff/1/src/d8.cc#newcode1555 src/d8.cc:1555: fake_argv[1] = strdup("--trace-hydrogen-file=hydrogen.cfg"); On 2013/07/25 14:00:34, titzer wrote: > ...

7 years, 5 months ago (2013-07-25 14:11:31 UTC) #3

Michael Starzinger

7 years, 5 months ago (2013-07-25 14:11:59 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r15882 (presubmit successful).

Expand Messages | Collapse Messages

Issue 20204005: Make standalone D8 trace to single hydrogen.cfg file. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addessed comments by Ben Titzer. #

Messages