Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: components/cronet/android/api/src/org/chromium/net/CronetEngine.java

Issue 2020373002: [Cronet] Call System.loadLibrary() from impl not API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@implpack
Patch Set: sync Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/cronet/android/java/src/org/chromium/net/impl/CronetLibraryLoader.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/android/api/src/org/chromium/net/CronetEngine.java
diff --git a/components/cronet/android/api/src/org/chromium/net/CronetEngine.java b/components/cronet/android/api/src/org/chromium/net/CronetEngine.java
index e0ea49b9bd55b12b2731fafeb6cda3a9209c86bf..4e8b57b681a652040e4a26c5ea9f7fb58d0158f1 100644
--- a/components/cronet/android/api/src/org/chromium/net/CronetEngine.java
+++ b/components/cronet/android/api/src/org/chromium/net/CronetEngine.java
@@ -247,6 +247,13 @@ public abstract class CronetEngine {
}
/**
+ * @hide only used by internal implementation.
+ */
+ public String libraryName() {
+ return mLibraryName;
+ }
+
+ /**
* Sets a {@link LibraryLoader} to be used to load the native library.
* If not set, the library will be loaded using {@link System#loadLibrary}.
* @param loader {@code LibraryLoader} to be used to load the native library.
@@ -260,12 +267,8 @@ public abstract class CronetEngine {
/**
* @hide only used by internal implementation.
*/
- public void loadLibrary() {
- if (mLibraryLoader == null) {
- System.loadLibrary(mLibraryName);
- } else {
- mLibraryLoader.loadLibrary(mLibraryName);
- }
+ public LibraryLoader libraryLoader() {
+ return mLibraryLoader;
}
/**
« no previous file with comments | « no previous file | components/cronet/android/java/src/org/chromium/net/impl/CronetLibraryLoader.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698