Remove unused LoadString values, cleanup remaining strings.

Remove unused LoadString values, cleanup remaining strings.

These strings are not used anywhere, remove the defines and the strings. For the remaining strings, cleanup the contents.

Committed: https://pdfium.googlesource.com/pdfium/+/0e0a86a34783d4844d9cd78bb3437034e54f4581

[dsinclair, 2016-06-01 15:30:26]

Description was changed from

==========
Remove unused LoadString values

These strings are not used anywhere, remove the defines and the strings.
==========

to

==========
Remove unused LoadString values, cleanup remaining strings.

These strings are not used anywhere, remove the defines and the strings. For the
remaining strings, cleanup the contents.
==========

[dsinclair, 2016-06-01 15:30:49]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2016-06-01 15:30:50]

PTAL.

https://codereview.chromium.org/2020353004/diff/1/fpdfsdk/fpdfxfa/fpdfxfa_app...
File fpdfsdk/fpdfxfa/fpdfxfa_app.cpp (right):

https://codereview.chromium.org/2020353004/diff/1/fpdfsdk/fpdfxfa/fpdfxfa_app...
fpdfsdk/fpdfxfa/fpdfxfa_app.cpp:275: wsString = L"PDFium";
I renamed this to PDFium as I thought it made more sense.

[Tom Sepez, 2016-06-01 17:58:18]

lgtm

https://codereview.chromium.org/2020353004/diff/1/fpdfsdk/fpdfxfa/fpdfxfa_app...
File fpdfsdk/fpdfxfa/fpdfxfa_app.cpp (right):

https://codereview.chromium.org/2020353004/diff/1/fpdfsdk/fpdfxfa/fpdfxfa_app...
fpdfsdk/fpdfxfa/fpdfxfa_app.cpp:260: void CPDFXFA_App::LoadString(int32_t
iStringID, CFX_WideString& wsString) {
follow-up: return string as value.

https://codereview.chromium.org/2020353004/diff/1/fpdfsdk/fpdfxfa/fpdfxfa_app...
fpdfsdk/fpdfxfa/fpdfxfa_app.cpp:275: wsString = L"PDFium";
On 2016/06/01 15:30:50, dsinclair wrote:
> I renamed this to PDFium as I thought it made more sense.

Acknowledged.

https://codereview.chromium.org/2020353004/diff/1/fpdfsdk/fpdfxfa/fpdfxfa_app...
fpdfsdk/fpdfxfa/fpdfxfa_app.cpp:335: wsString = FX_WSTRC(
pointless WSTRC (several places).

[Lei Zhang, 2016-06-01 18:10:17]

https://codereview.chromium.org/2020353004/diff/1/fpdfsdk/fpdfxfa/fpdfxfa_app...
File fpdfsdk/fpdfxfa/fpdfxfa_app.cpp (right):

https://codereview.chromium.org/2020353004/diff/1/fpdfsdk/fpdfxfa/fpdfxfa_app...
fpdfsdk/fpdfxfa/fpdfxfa_app.cpp:275: wsString = L"PDFium";
BTW, JS_STR_VIEWERTYPE is "pdfium"

[dsinclair, 2016-06-01 19:30:42]

https://codereview.chromium.org/2020353004/diff/1/fpdfsdk/fpdfxfa/fpdfxfa_app...
File fpdfsdk/fpdfxfa/fpdfxfa_app.cpp (right):

https://codereview.chromium.org/2020353004/diff/1/fpdfsdk/fpdfxfa/fpdfxfa_app...
fpdfsdk/fpdfxfa/fpdfxfa_app.cpp:260: void CPDFXFA_App::LoadString(int32_t
iStringID, CFX_WideString& wsString) {
On 2016/06/01 17:58:18, Tom Sepez wrote:
> follow-up: return string as value.  

Acknowledged.

https://codereview.chromium.org/2020353004/diff/1/fpdfsdk/fpdfxfa/fpdfxfa_app...
fpdfsdk/fpdfxfa/fpdfxfa_app.cpp:275: wsString = L"PDFium";
On 2016/06/01 18:10:17, Lei Zhang wrote:
> BTW, JS_STR_VIEWERTYPE is "pdfium"

Switched to pdfium.

https://codereview.chromium.org/2020353004/diff/1/fpdfsdk/fpdfxfa/fpdfxfa_app...
fpdfsdk/fpdfxfa/fpdfxfa_app.cpp:335: wsString = FX_WSTRC(
On 2016/06/01 17:58:18, Tom Sepez wrote:
> pointless WSTRC (several places).

Done.

[dsinclair, 2016-06-02 01:37:53]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-06-02 01:37:54]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2020353004/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-06-02 01:38:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2020353004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2020353004/40001

[commit-bot: I haz the power, 2016-06-02 01:56:55]

Description was changed from

==========
Remove unused LoadString values, cleanup remaining strings.

These strings are not used anywhere, remove the defines and the strings. For the
remaining strings, cleanup the contents.
==========

to

==========
Remove unused LoadString values, cleanup remaining strings.

These strings are not used anywhere, remove the defines and the strings. For the
remaining strings, cleanup the contents.

Committed:
https://pdfium.googlesource.com/pdfium/+/0e0a86a34783d4844d9cd78bb3437034e54f...
==========

[commit-bot: I haz the power, 2016-06-02 01:56:56]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/0e0a86a34783d4844d9cd78bb3437034e54f...