Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1437)

Unified Diff: src/compiler/verifier.cc

Issue 2020323004: [turbofan] Remove eager frame state from all nodes. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_turbofan-checkpoint-3
Patch Set: Rebased. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/operator-properties.cc ('k') | src/compiler/wasm-compiler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/verifier.cc
diff --git a/src/compiler/verifier.cc b/src/compiler/verifier.cc
index 3375d410fd81120c6770339165be43771b0984cc..f7d22ff188cc82e1919e77327731027c15372139 100644
--- a/src/compiler/verifier.cc
+++ b/src/compiler/verifier.cc
@@ -112,7 +112,7 @@ void Verifier::Visitor::Check(Node* node) {
// Verify that frame state has been inserted for the nodes that need it.
for (int i = 0; i < frame_state_count; i++) {
- Node* frame_state = NodeProperties::GetFrameStateInput(node, i);
+ Node* frame_state = NodeProperties::GetFrameStateInput(node);
CHECK(frame_state->opcode() == IrOpcode::kFrameState ||
// kFrameState uses Start as a sentinel.
(node->opcode() == IrOpcode::kFrameState &&
@@ -1531,10 +1531,9 @@ void Verifier::VerifyNode(Node* node) {
}
}
}
- // Frame state inputs should be frame states (or sentinels).
- for (int i = 0; i < OperatorProperties::GetFrameStateInputCount(node->op());
- i++) {
- Node* input = NodeProperties::GetFrameStateInput(node, i);
+ // Frame state input should be a frame state (or sentinel).
+ if (OperatorProperties::GetFrameStateInputCount(node->op()) > 0) {
+ Node* input = NodeProperties::GetFrameStateInput(node);
CHECK(input->opcode() == IrOpcode::kFrameState ||
input->opcode() == IrOpcode::kStart ||
input->opcode() == IrOpcode::kDead);
« no previous file with comments | « src/compiler/operator-properties.cc ('k') | src/compiler/wasm-compiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698