Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: src/compiler/js-inlining-heuristic.cc

Issue 2020323004: [turbofan] Remove eager frame state from all nodes. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_turbofan-checkpoint-3
Patch Set: Rebased. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/js-inlining.cc ('k') | src/compiler/js-intrinsic-lowering.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/js-inlining-heuristic.h" 5 #include "src/compiler/js-inlining-heuristic.h"
6 6
7 #include "src/compiler.h" 7 #include "src/compiler.h"
8 #include "src/compiler/node-matchers.h" 8 #include "src/compiler/node-matchers.h"
9 #include "src/objects-inl.h" 9 #include "src/objects-inl.h"
10 10
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 if (function->shared()->ast_node_count() > FLAG_max_inlined_nodes) { 60 if (function->shared()->ast_node_count() > FLAG_max_inlined_nodes) {
61 return NoChange(); 61 return NoChange();
62 } 62 }
63 63
64 // Avoid inlining within or across the boundary of asm.js code. 64 // Avoid inlining within or across the boundary of asm.js code.
65 if (info_->shared_info()->asm_function()) return NoChange(); 65 if (info_->shared_info()->asm_function()) return NoChange();
66 if (function->shared()->asm_function()) return NoChange(); 66 if (function->shared()->asm_function()) return NoChange();
67 67
68 // Stop inlinining once the maximum allowed level is reached. 68 // Stop inlinining once the maximum allowed level is reached.
69 int level = 0; 69 int level = 0;
70 for (Node* frame_state = NodeProperties::GetFrameStateInput(node, 0); 70 for (Node* frame_state = NodeProperties::GetFrameStateInput(node);
71 frame_state->opcode() == IrOpcode::kFrameState; 71 frame_state->opcode() == IrOpcode::kFrameState;
72 frame_state = NodeProperties::GetFrameStateInput(frame_state, 0)) { 72 frame_state = NodeProperties::GetFrameStateInput(frame_state)) {
73 if (++level > FLAG_max_inlining_levels) return NoChange(); 73 if (++level > FLAG_max_inlining_levels) return NoChange();
74 } 74 }
75 75
76 // Gather feedback on how often this call site has been hit before. 76 // Gather feedback on how often this call site has been hit before.
77 int calls = -1; // Same default as CallICNexus::ExtractCallCount. 77 int calls = -1; // Same default as CallICNexus::ExtractCallCount.
78 if (node->opcode() == IrOpcode::kJSCallFunction) { 78 if (node->opcode() == IrOpcode::kJSCallFunction) {
79 CallFunctionParameters p = CallFunctionParametersOf(node->op()); 79 CallFunctionParameters p = CallFunctionParametersOf(node->op());
80 if (p.feedback().IsValid()) { 80 if (p.feedback().IsValid()) {
81 CallICNexus nexus(p.feedback().vector(), p.feedback().slot()); 81 CallICNexus nexus(p.feedback().vector(), p.feedback().slot());
82 calls = nexus.ExtractCallCount(); 82 calls = nexus.ExtractCallCount();
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 candidate.node->id(), candidate.calls, 146 candidate.node->id(), candidate.calls,
147 candidate.function->shared()->SourceSize(), 147 candidate.function->shared()->SourceSize(),
148 candidate.function->shared()->ast_node_count(), 148 candidate.function->shared()->ast_node_count(),
149 candidate.function->shared()->DebugName()->ToCString().get()); 149 candidate.function->shared()->DebugName()->ToCString().get());
150 } 150 }
151 } 151 }
152 152
153 } // namespace compiler 153 } // namespace compiler
154 } // namespace internal 154 } // namespace internal
155 } // namespace v8 155 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/js-inlining.cc ('k') | src/compiler/js-intrinsic-lowering.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698