Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2020293004: Conditionally enable SDK summaries in server (Closed)

Created:
4 years, 6 months ago by Brian Wilkerson
Modified:
4 years, 6 months ago
Reviewers:
scheglov, pquitslund
CC:
reviews_dartlang.org, pquitslund, jwren
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M pkg/analysis_server/lib/src/server/driver.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/handle.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/sdk.dart View 1 chunk +1 line, -6 lines 2 comments Download

Messages

Total messages: 7 (3 generated)
Brian Wilkerson
https://codereview.chromium.org/2020293004/diff/1/pkg/analyzer/lib/src/generated/sdk.dart File pkg/analyzer/lib/src/generated/sdk.dart (right): https://codereview.chromium.org/2020293004/diff/1/pkg/analyzer/lib/src/generated/sdk.dart#newcode127 pkg/analyzer/lib/src/generated/sdk.dart:127: return sdkMap.putIfAbsent(encoding, () => sdkCreator(options)); This is just code ...
4 years, 6 months ago (2016-06-01 04:16:51 UTC) #2
pquitslund
LGTM! https://codereview.chromium.org/2020293004/diff/1/pkg/analyzer/lib/src/generated/sdk.dart File pkg/analyzer/lib/src/generated/sdk.dart (right): https://codereview.chromium.org/2020293004/diff/1/pkg/analyzer/lib/src/generated/sdk.dart#newcode127 pkg/analyzer/lib/src/generated/sdk.dart:127: return sdkMap.putIfAbsent(encoding, () => sdkCreator(options)); On 2016/06/01 04:16:51, ...
4 years, 6 months ago (2016-06-01 04:28:17 UTC) #4
scheglov
LGTM
4 years, 6 months ago (2016-06-01 04:31:41 UTC) #5
Brian Wilkerson
4 years, 6 months ago (2016-06-09 16:59:04 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
800a54354a22c9c5fc239fe5560cba370ad8bf80 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698