Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2020263004: Revert of [Android] Add five APK targets to gn_all. (Closed)

Created:
4 years, 6 months ago by jbudorick
Modified:
4 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, maxbogue
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Add five APK targets to gn_all. (patchset #1 id:1 of https://codereview.chromium.org/2024923002/ ) Reason for revert: chromium_linker_test_apk doesn't exist on x64 Original issue's description: > [Android] Add five APK targets to gn_all. > > BUG= > > Committed: https://crrev.com/5d0af4b4cd4b660b660ed3f9b2abfa04dcb9dca9 > Cr-Commit-Position: refs/heads/master@{#396923} TBR=dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/75dde5533c6c8e0cdaca4f0e1288904834d4cee2 Cr-Commit-Position: refs/heads/master@{#396997}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M BUILD.gn View 3 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jbudorick
Created Revert of [Android] Add five APK targets to gn_all.
4 years, 6 months ago (2016-06-01 00:46:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2020263004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2020263004/1
4 years, 6 months ago (2016-06-01 00:47:18 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 00:48:42 UTC) #4
Dirk Pranke
lgtm
4 years, 6 months ago (2016-06-01 00:49:19 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 00:51:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/75dde5533c6c8e0cdaca4f0e1288904834d4cee2
Cr-Commit-Position: refs/heads/master@{#396997}

Powered by Google App Engine
This is Rietveld 408576698