Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Unified Diff: chrome/browser/push_messaging/background_budget_service_unittest.cc

Issue 2020263002: Added code to make sure that the budget service does sane things if the clock rolls backwards. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Code review comments integrated Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/push_messaging/background_budget_service.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/push_messaging/background_budget_service_unittest.cc
diff --git a/chrome/browser/push_messaging/background_budget_service_unittest.cc b/chrome/browser/push_messaging/background_budget_service_unittest.cc
index 75c34893bf5056227f33e8e679a9d1f329267d4e..2412c6194cf811ca1ce133fa3a6d0363f0929127 100644
--- a/chrome/browser/push_messaging/background_budget_service_unittest.cc
+++ b/chrome/browser/push_messaging/background_budget_service_unittest.cc
@@ -214,3 +214,28 @@ TEST_F(BackgroundBudgetServiceTest, GetBudgetInvalidBudget) {
EXPECT_DOUBLE_EQ(budget, kTestSES);
}
+
+TEST_F(BackgroundBudgetServiceTest, GetBudgetNegativeTime) {
+ // Manually construct a BackgroundBudgetService with a clock that the test
+ // can control so that we can fast forward in time.
+ BackgroundBudgetService* service = GetService();
+ base::SimpleTestClock* clock = SetClockForTesting();
+ base::Time starting_time = clock->Now();
+
+ // Set initial SES and budget values.
+ const GURL origin(kTestOrigin);
+ SetSiteEngagementScore(origin, kTestSES);
+ service->StoreBudget(origin, kTestBudget);
+
+ // Move time forward an hour and get the budget.
+ clock->SetNow(starting_time + base::TimeDelta::FromHours(1));
+ double budget = service->GetBudget(origin);
+ service->StoreBudget(origin, budget);
+ EXPECT_NE(kTestBudget, budget);
+
+ // Now move time backwards a day and make sure that the current
+ // budget matches the budget of the most foward time.
+ clock->SetNow(starting_time - base::TimeDelta::FromDays(1));
+ double back_budget = service->GetBudget(origin);
+ EXPECT_NEAR(budget, back_budget, 0.01);
+}
« no previous file with comments | « chrome/browser/push_messaging/background_budget_service.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698