chrome/browser/about_flags.cc - Issue 2020243004: content: Rename num raster threads -> num worker threads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/about_flags.cc

Issue 2020243004: content: Rename num raster threads -> num worker threads. Base URL: https://chromium.googlesource.com/chromium/src.git@categorized_worker_pool_3

Patch Set: build break Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/app/generated_resources.grd ('K') | « chrome/app/generated_resources.grd ('k') | chrome/browser/chromeos/login/chrome_restart_request.cc » ('j') | content/public/common/content_switches.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/about_flags.cc

diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc

index 7ba58da254c70cffeadf808abba56d72c096370b..bbf25f9dfa0c294dbed3187360ec63aa0a7b1916 100644

--- a/chrome/browser/about_flags.cc

+++ b/chrome/browser/about_flags.cc

@@ -285,13 +285,16 @@ const FeatureEntry::Choice kReaderModeHeuristicsChoices[] = {

};

#endif

-const FeatureEntry::Choice kNumRasterThreadsChoices[] = {

- { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },

- { IDS_FLAGS_NUM_RASTER_THREADS_ONE, switches::kNumRasterThreads, "1" },

- { IDS_FLAGS_NUM_RASTER_THREADS_TWO, switches::kNumRasterThreads, "2" },

- { IDS_FLAGS_NUM_RASTER_THREADS_THREE, switches::kNumRasterThreads, "3" },

- { IDS_FLAGS_NUM_RASTER_THREADS_FOUR, switches::kNumRasterThreads, "4" }

-};

+const FeatureEntry::Choice kNumCategorizedWorkerThreadsChoices[] = {

+ {IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", ""},

+ {IDS_FLAGS_NUM_CATEGORIZED_WORKER_THREADS_ONE,

+ switches::kNumCategorizedWorkerThreads, "1"},

+ {IDS_FLAGS_NUM_CATEGORIZED_WORKER_THREADS_TWO,

+ switches::kNumCategorizedWorkerThreads, "2"},

+ {IDS_FLAGS_NUM_CATEGORIZED_WORKER_THREADS_THREE,

+ switches::kNumCategorizedWorkerThreads, "3"},

+ {IDS_FLAGS_NUM_CATEGORIZED_WORKER_THREADS_FOUR,

+ switches::kNumCategorizedWorkerThreads, "4"}};

const FeatureEntry::Choice kGpuRasterizationMSAASampleCountChoices[] = {

{ IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT,

@@ -1275,9 +1278,10 @@ const FeatureEntry kFeatureEntries[] = {

IDS_FLAGS_READER_MODE_HEURISTICS_DESCRIPTION, kOsAndroid,

MULTI_VALUE_TYPE(kReaderModeHeuristicsChoices)},

#endif

- {"num-raster-threads", IDS_FLAGS_NUM_RASTER_THREADS_NAME,

- IDS_FLAGS_NUM_RASTER_THREADS_DESCRIPTION, kOsAll,

- MULTI_VALUE_TYPE(kNumRasterThreadsChoices)},

+ {"num-categorized-worker-threads",

+ IDS_FLAGS_NUM_CATEGORIZED_WORKER_THREADS_NAME,

+ IDS_FLAGS_NUM_CATEGORIZED_WORKER_THREADS_DESCRIPTION, kOsAll,

+ MULTI_VALUE_TYPE(kNumCategorizedWorkerThreadsChoices)},

{"enable-permission-action-reporting",

IDS_FLAGS_PERMISSION_ACTION_REPORTING_NAME,

IDS_FLAGS_PERMISSION_ACTION_REPORTING_DESCRIPTION, kOsAll,