Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(649)

Issue 2020143002: Get rid of a redundant FrameSelection::setSelection() with VisibleSelectionInFlatTree (Closed)

Created:
4 years, 3 months ago by yosin_UTC9
Modified:
4 years, 3 months ago
Reviewers:
yoichio
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Get rid of a redundant FrameSelection::setSelection() with VisibleSelectionInFlatTree This patch gets rid of a redundant |FrameSelection::setSelection()| with |VisibleSelectionInFlatTree|, since there is one call site, to simplify source code for improving code health. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/205aa7069735c0c05a0d18ca20e0de53054f90c0 Cr-Commit-Position: refs/heads/master@{#396792}

Patch Set 1 : 2016-05-31T13:04:09 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/core/editing/FrameSelection.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
yosin_UTC9
PTAL
4 years, 3 months ago (2016-05-31 04:49:43 UTC) #4
yoichio
lgtm
4 years, 3 months ago (2016-05-31 05:52:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2020143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2020143002/1
4 years, 3 months ago (2016-05-31 06:03:49 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-05-31 06:08:16 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-05-31 06:09:43 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/205aa7069735c0c05a0d18ca20e0de53054f90c0
Cr-Commit-Position: refs/heads/master@{#396792}

Powered by Google App Engine
This is Rietveld 408576698