third_party/WebKit/LayoutTests/fast/css/sticky/sticky-clip-rel-child-expected.html - Issue 2020103002: Fix sticky constraints and update sticky layer positions recursively after scroll.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/css/sticky/sticky-clip-rel-child-expected.html

Issue 2020103002: Fix sticky constraints and update sticky layer positions recursively after scroll. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix bugs with overflow scrollers in sticky position constraints, add unit tests, and test clipped b… Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/sticky/sticky-clip-rel-child.html ('k') | third_party/WebKit/Source/core/core.gypi » ('j') | third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 body {

	4 height: 2000px;

	5 margin: 0;

	6 }

	7 .sticky {

	8 background: red;

	9 height: 100px;

	10 width: 100px;

	11 overflow: hidden;

	12 position: relative;

	13 top: 100px;

	14 }

	15 .relative {

	16 background: green;

	17 height: 100px;

	18 width: 100px;

	19 position: relative;

	20 }

	21 #scroller {

	22 left: 200px;

	23 top: 100px;

	24 height: 100px;

	25 width: 120px;

	26 overflow: auto;

	27 position: absolute;

	28 }

	29 .spacer {

	30 height: 1000px;

	31 }

	32 </style>

	33 <script>

	34 function doTest() {

	35 window.scrollTo(0, 100);

	36 document.getElementById('scroller').scrollTop = 100;

	37 }

	38 window.addEventListener('load', doTest, false);

	39 </script>

	40 <div class="sticky">

	41 <div class="relative">

	42 </div>

	43 </div>

	44 <div id="scroller">

	45 <div class="sticky">

	46 <div class="relative">
	chrishtr 2016/06/06 22:18:39 Was the bug that it wasn't including the bounds of Was the bug that it wasn't including the bounds of positioned descendants? flackr 2016/06/09 17:13:32 Because the relative positioned element is clipped Show quoted text On 2016/06/06 at 22:18:39, chrishtr wrote: > Was the bug that it wasn't including the bounds of positioned descendants? Because the relative positioned element is clipped by sticky element, it gets a separate PaintLayer. The bug was that the relative position element's position was not being updated on scroll. This was basically the minimal repro from the original bug but I suspect there may be other ways to reproduce this problem.
	47 </div>

	48 </div>

	49 <div class="spacer"></div>

	50 </div>

	51

OLD	NEW