MD User Manager: Browser Tests for when all profiles are locked.

MD User Manager: Browser Tests for when all profiles are locked.

BUG=563722
Committed: https://crrev.com/99a744d93ec7709dfd68fac487c705549bae8d79
Cr-Commit-Position: refs/heads/master@{#397150}

[Moe, 2016-05-30 20:12:48]

mahmadi@chromium.org changed reviewers:
+ dpapad@chromium.org

[Moe, 2016-05-30 20:12:49]

Demetrios, Please review this CL.

PS. MD User Manager browser tests are currently disabled due to flakiness. This
CL will wait until https://codereview.chromium.org/2007133006/ lands.

[dpapad, 2016-05-31 22:07:42]

I think this CL needs to be updated according to changes in
profile_browser_proxy.js at https://codereview.chromium.org/2025433002.

https://codereview.chromium.org/2020093002/diff/1/chrome/test/data/webui/md_u...
File chrome/test/data/webui/md_user_manager/control_bar_tests.js (right):

https://codereview.chromium.org/2020093002/diff/1/chrome/test/data/webui/md_u...
chrome/test/data/webui/md_user_manager/control_bar_tests.js:9: controlBarElement
= document.createElement('control-bar');
I don't think you want to declare a global var here.

var controlBarElement = document.createElement('control-bar');

https://codereview.chromium.org/2020093002/diff/1/chrome/test/data/webui/md_u...
File chrome/test/data/webui/md_user_manager/test_profile_browser_proxy.js
(right):

https://codereview.chromium.org/2020093002/diff/1/chrome/test/data/webui/md_u...
chrome/test/data/webui/md_user_manager/test_profile_browser_proxy.js:22:
'isAtLeastOneProfileUnlocked',
After latest changes to the previous CL this should be areAllProfilesLocked.

https://codereview.chromium.org/2020093002/diff/1/chrome/test/data/webui/md_u...
chrome/test/data/webui/md_user_manager/test_profile_browser_proxy.js:72:
setAtLeastOneProfileUnlocked_: function(atLeastOneProfileUnlocked) {
This is called by other classes, should be made public. Also @param missing.

https://codereview.chromium.org/2020093002/diff/1/chrome/test/data/webui/md_u...
chrome/test/data/webui/md_user_manager/test_profile_browser_proxy.js:126:
Promise.reject();
After your latest changes to the other CL, this should be
return Promise.resolve(this.atLeastOneProfileUnlocked_);

[Moe, 2016-05-31 22:47:39]

https://codereview.chromium.org/2020093002/diff/1/chrome/test/data/webui/md_u...
File chrome/test/data/webui/md_user_manager/control_bar_tests.js (right):

https://codereview.chromium.org/2020093002/diff/1/chrome/test/data/webui/md_u...
chrome/test/data/webui/md_user_manager/control_bar_tests.js:9: controlBarElement
= document.createElement('control-bar');
On 2016/05/31 22:07:41, dpapad wrote:
> I don't think you want to declare a global var here.
> 
> var controlBarElement = document.createElement('control-bar');

Done.

https://codereview.chromium.org/2020093002/diff/1/chrome/test/data/webui/md_u...
File chrome/test/data/webui/md_user_manager/test_profile_browser_proxy.js
(right):

https://codereview.chromium.org/2020093002/diff/1/chrome/test/data/webui/md_u...
chrome/test/data/webui/md_user_manager/test_profile_browser_proxy.js:22:
'isAtLeastOneProfileUnlocked',
On 2016/05/31 22:07:41, dpapad wrote:
> After latest changes to the previous CL this should be areAllProfilesLocked.

Done.

https://codereview.chromium.org/2020093002/diff/1/chrome/test/data/webui/md_u...
chrome/test/data/webui/md_user_manager/test_profile_browser_proxy.js:72:
setAtLeastOneProfileUnlocked_: function(atLeastOneProfileUnlocked) {
On 2016/05/31 22:07:41, dpapad wrote:
> This is called by other classes, should be made public. Also @param missing.

Done.

https://codereview.chromium.org/2020093002/diff/1/chrome/test/data/webui/md_u...
chrome/test/data/webui/md_user_manager/test_profile_browser_proxy.js:126:
Promise.reject();
On 2016/05/31 22:07:41, dpapad wrote:
> After your latest changes to the other CL, this should be
> return Promise.resolve(this.atLeastOneProfileUnlocked_);

Done.

[dpapad, 2016-05-31 23:23:45]

lgtm

[Moe, 2016-06-01 15:34:09]

On 2016/05/31 23:23:45, dpapad wrote:
> lgtm

Thank you.

[Moe, 2016-06-01 15:34:14]

The CQ bit was checked by mahmadi@chromium.org

[commit-bot: I haz the power, 2016-06-01 15:34:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2020093002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2020093002/20001

[commit-bot: I haz the power, 2016-06-01 15:38:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-01 15:39:46]

Description was changed from

==========
MD User Manager: Browser Tests for when all profiles are locked.

BUG=563722
==========

to

==========
MD User Manager: Browser Tests for when all profiles are locked.

BUG=563722

Committed: https://crrev.com/99a744d93ec7709dfd68fac487c705549bae8d79
Cr-Commit-Position: refs/heads/master@{#397150}
==========

[commit-bot: I haz the power, 2016-06-01 15:39:47]

Patchset 2 (id:??) landed as
https://crrev.com/99a744d93ec7709dfd68fac487c705549bae8d79
Cr-Commit-Position: refs/heads/master@{#397150}