chrome/browser/notifications/platform_notification_service_interactive_uitest.cc - Issue 2020063003: Use GetPermissionStatus instead of DesktopNotificationProfileUtil::GetContentSetting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/platform_notification_service_interactive_uitest.cc

Issue 2020063003: Use GetPermissionStatus instead of DesktopNotificationProfileUtil::GetContentSetting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove embber param for notifications Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/preferences/website_preference_bridge.cc ('K') | « chrome/browser/notifications/platform_notification_service_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/platform_notification_service_interactive_uitest.cc

diff --git a/chrome/browser/notifications/platform_notification_service_interactive_uitest.cc b/chrome/browser/notifications/platform_notification_service_interactive_uitest.cc

index 71faf4c6454d7ce72997d59e8298702561cc1ecf..5e6ca28abcce580f13e2e4b59f6f5a39846f8486 100644

--- a/chrome/browser/notifications/platform_notification_service_interactive_uitest.cc

+++ b/chrome/browser/notifications/platform_notification_service_interactive_uitest.cc

@@ -140,9 +140,10 @@ void PlatformNotificationServiceBrowserTest::

GURL origin = TestPageUrl().GetOrigin();

DesktopNotificationProfileUtil::GrantPermission(browser()->profile(), origin);

- ASSERT_EQ(CONTENT_SETTING_ALLOW,

- DesktopNotificationProfileUtil::GetContentSetting(

- browser()->profile(), origin));

+ ASSERT_EQ(blink::mojom::PermissionStatus::GRANTED,

+ PermissionManager::Get(browser()->profile())

+ ->GetPermissionStatus(content::PermissionType::NOTIFICATIONS,

+ origin, origin));

}

void PlatformNotificationServiceBrowserTest::NavigateToTestPage(