Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2020063002: Use counter for mixing old and new constraints (Closed)

Created:
4 years, 6 months ago by hta - Chromium
Modified:
4 years, 6 months ago
CC:
chromium-reviews, blink-reviews, haraken, tommyw+watchlist_chromium.org, asvitkine+watch_chromium.org, mcasas+watch+mediastream_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use counter for mixing old and new constraints Before new constraints landed, they were ignored. After landing, using old and new at the same time gives TypeError. This counter can give some information about how many users will be affected. BUG=287805 Committed: https://crrev.com/d9c326e108e487af99ac75a3b7e25c551f4e1f08 Cr-Commit-Position: refs/heads/master@{#397313}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
hta - Chromium
3 files, 1 reviewer per file. Small CL - adds a counter.
4 years, 6 months ago (2016-05-30 20:39:52 UTC) #4
tommi (sloooow) - chröme
lgtm
4 years, 6 months ago (2016-05-31 07:43:42 UTC) #5
Steven Holte
lgtm
4 years, 6 months ago (2016-05-31 21:56:20 UTC) #6
Nate Chapin
lgtm
4 years, 6 months ago (2016-06-01 23:54:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2020063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2020063002/1
4 years, 6 months ago (2016-06-02 04:35:21 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/14857) ios-device-gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 6 months ago (2016-06-02 04:37:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2020063002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2020063002/20001
4 years, 6 months ago (2016-06-02 04:45:06 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/103770)
4 years, 6 months ago (2016-06-02 05:03:06 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2020063002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2020063002/20001
4 years, 6 months ago (2016-06-02 05:19:01 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-02 06:30:56 UTC) #20
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 06:32:44 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d9c326e108e487af99ac75a3b7e25c551f4e1f08
Cr-Commit-Position: refs/heads/master@{#397313}

Powered by Google App Engine
This is Rietveld 408576698