gpu: Increase Skia resource cache item limit

gpu: Increase Skia resource cache item limit

Increase Skia GrContext resource cache item limit.
MS Chalkboard test case has 2400 paths. The old limit
would cause path cache trashing when the scene was
played back.

Fixes slowness on
smoothness.gpu_rasterization.tough_path_rendering_cases
on hardware that has GL API level path rendering enabled.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/b39a64b62634ed2c88cea394b001243b1d0e654e
Cr-Commit-Position: refs/heads/master@{#397379}

[Kimmo Kinnunen, 2016-05-30 11:26:19]

Description was changed from

==========
gpu: Increase Skia resource cache item limit

Increase Skia GrContext resource cache item limit.
MS Chalkboard test case has 2400 paths. The old limit
would cause path cache trashing when the scene was
played back.

Fixes slowness on
smoothness.gpu_rasterization.tough_path_rendering_cases
on hardware that has GL API level path rendering enabled.
==========

to

==========
gpu: Increase Skia resource cache item limit

Increase Skia GrContext resource cache item limit.
MS Chalkboard test case has 2400 paths. The old limit
would cause path cache trashing when the scene was
played back.

Fixes slowness on
smoothness.gpu_rasterization.tough_path_rendering_cases
on hardware that has GL API level path rendering enabled.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Kimmo Kinnunen, 2016-05-30 11:29:32]

kkinnunen@nvidia.com changed reviewers:
+ piman@chromium.org, sievers@chromium.org

[Kimmo Kinnunen, 2016-05-30 11:29:32]

I recall bsalomon saying that the item count limit was invented due to some old
mobile GL implementation slowing down after big number of texture allocations.
He mentioned that this was a problem before Skia used texture atlases for text.

Skia testing itself uses the item count limit limit proposed here.

[piman, 2016-05-31 15:49:19]

piman@chromium.org changed reviewers:
+ bsalomon@chromium.org, ericrk@chromium.org

[piman, 2016-05-31 15:49:20]

+ericrk/bsalomon: is there a memory cost here?

[bsalomon, 2016-05-31 16:17:49]

On 2016/05/31 15:49:20, piman OOO back 2016-5-31 wrote:
> +ericrk/bsalomon: is there a memory cost here?

Skia's cache purges when either the Byte or Count limit is hit. So, if we are
indeed hitting the Count limit, then this would cause us to use more memory.
However, we'd still be limited by the 96MB Byte limit. The size accounting for
GL paths is pretty approximate (compared to other resource types), so whether
96MBs is really 96MBs is another question. On the other hand, GPUs that support
NVPR tend to have >> 96MB VRAM.

[piman, 2016-05-31 16:46:15]

lgtm

[Kimmo Kinnunen, 2016-06-02 11:20:44]

The CQ bit was checked by kkinnunen@nvidia.com

[commit-bot: I haz the power, 2016-06-02 11:21:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-02 11:21:04]

This CL has an open dependency (Issue 1876363005 Patch 60001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[Kimmo Kinnunen, 2016-06-02 11:28:52]

The CQ bit was checked by kkinnunen@nvidia.com

[Kimmo Kinnunen, 2016-06-02 11:28:53]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/2020013002/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-06-02 11:29:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2020013002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2020013002/20001

[commit-bot: I haz the power, 2016-06-02 13:04:16]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-02 13:06:37]

Description was changed from

==========
gpu: Increase Skia resource cache item limit

Increase Skia GrContext resource cache item limit.
MS Chalkboard test case has 2400 paths. The old limit
would cause path cache trashing when the scene was
played back.

Fixes slowness on
smoothness.gpu_rasterization.tough_path_rendering_cases
on hardware that has GL API level path rendering enabled.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
gpu: Increase Skia resource cache item limit

Increase Skia GrContext resource cache item limit.
MS Chalkboard test case has 2400 paths. The old limit
would cause path cache trashing when the scene was
played back.

Fixes slowness on
smoothness.gpu_rasterization.tough_path_rendering_cases
on hardware that has GL API level path rendering enabled.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/b39a64b62634ed2c88cea394b001243b1d0e654e
Cr-Commit-Position: refs/heads/master@{#397379}
==========

[commit-bot: I haz the power, 2016-06-02 13:06:38]

Patchset 2 (id:??) landed as
https://crrev.com/b39a64b62634ed2c88cea394b001243b1d0e654e
Cr-Commit-Position: refs/heads/master@{#397379}