Set "auto" as default for rx and ry

Set "auto" as default for rx and ry

Set initial value as "auto" for rx and ry.

BUG=576811
Committed: https://crrev.com/c9cc8c9d40aa52810ee6b29a0717948cfad5c20a
Cr-Commit-Position: refs/heads/master@{#397332}

[Shanmuga Pandi, 2016-05-30 10:45:53]

Description was changed from

==========
Set "auto" as default for rx and ry

BUG=576811
==========

to

==========
Set "auto" as default for rx and ry

Set initial value as "auto" for rx and ry.

BUG=576811
==========

[Shanmuga Pandi, 2016-05-30 10:45:53]

shanmuga.m@samsung.com changed reviewers:
+ rob.buis@samsung.com

[Shanmuga Pandi, 2016-05-30 10:46:14]

On 2016/05/30 10:45:53, Shanmuga Pandi wrote:
> mailto:shanmuga.m@samsung.com changed reviewers:
> + mailto:rob.buis@samsung.com

PTAL!!

Thanks

[Shanmuga Pandi, 2016-05-31 06:24:13]

shanmuga.m@samsung.com changed reviewers:
+ ed@chromium.org, fs@opera.com, pdr@google.com

[Shanmuga Pandi, 2016-05-31 06:25:04]

PTAL!!!

Thanks

[fs, 2016-05-31 10:34:52]

This looks mostly ok, but please also add tests for <rect> without 'rx' and 'ry'
(respectively) and where 'rx' and 'ry' is specified through style.

Note that 'auto' for 'rx' and 'ry' also applies to <ellipse>, so that could use
some tests too.

[Shanmuga Pandi, 2016-05-31 13:11:23]

On 2016/05/31 10:34:52, fs wrote:
> This looks mostly ok, but please also add tests for <rect> without 'rx' and
'ry'
> (respectively) and where 'rx' and 'ry' is specified through style.
> 
> Note that 'auto' for 'rx' and 'ry' also applies to <ellipse>, so that could
use
> some tests too.

Done!!
Thanks

[fs, 2016-05-31 13:25:49]

On 2016/05/31 at 13:11:23, shanmuga.m wrote:
> On 2016/05/31 10:34:52, fs wrote:
> > This looks mostly ok, but please also add tests for <rect> without 'rx' and
'ry'
> > (respectively) and where 'rx' and 'ry' is specified through style.
> > 
> > Note that 'auto' for 'rx' and 'ry' also applies to <ellipse>, so that could
use
> > some tests too.
> 
> Done!!
> Thanks

Still missing test where 'rx' and 'ry' are specified through style (CSS).

[Shanmuga Pandi, 2016-05-31 14:12:20]

On 2016/05/31 13:25:49, fs wrote:
> On 2016/05/31 at 13:11:23, shanmuga.m wrote:
> > On 2016/05/31 10:34:52, fs wrote:
> > > This looks mostly ok, but please also add tests for <rect> without 'rx'
and
> 'ry'
> > > (respectively) and where 'rx' and 'ry' is specified through style.
> > > 
> > > Note that 'auto' for 'rx' and 'ry' also applies to <ellipse>, so that
could
> use
> > > some tests too.
> > 
> > Done!!
> > Thanks
> 
> Still missing test where 'rx' and 'ry' are specified through style (CSS).

Sorry. Please check now.
Thanks

[fs, 2016-05-31 14:27:35]

https://codereview.chromium.org/2019993003/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/svg/custom/SVGRect-without-rx-or-ry-in-css-style.svg
(right):

https://codereview.chromium.org/2019993003/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/custom/SVGRect-without-rx-or-ry-in-css-style.svg:5:
height="100" fill="green" style="ry:10"/>
The case we want to test is style="ry: auto" and similar (when there's a 'ry'
attribute specified presumably.)

[Shanmuga Pandi, 2016-06-01 09:38:12]

Updated the TC.

https://codereview.chromium.org/2019993003/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/svg/custom/SVGRect-without-rx-or-ry-in-css-style.svg
(right):

https://codereview.chromium.org/2019993003/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/custom/SVGRect-without-rx-or-ry-in-css-style.svg:5:
height="100" fill="green" style="ry:10"/>
On 2016/05/31 14:27:35, fs wrote:
> The case we want to test is style="ry: auto" and similar (when there's a 'ry'
> attribute specified presumably.)

Done.

[fs, 2016-06-01 10:43:09]

https://codereview.chromium.org/2019993003/diff/80001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/svg/custom/SVGRect-without-rx-or-ry-in-css-style-expected.svg
(right):

https://codereview.chromium.org/2019993003/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/custom/SVGRect-without-rx-or-ry-in-css-style-expected.svg:3:
ry="10"
Since 'ry', from the inline style, would override the 'ry', from the
presentation attribute, this should render as if rx=ry=0. But I suggest adding a
'rx' (different from the 'ry' value). Ditto for the other case. (You need to add
support for parsing 'auto' from CSS as well.)

[Shanmuga Pandi, 2016-06-01 12:34:28]

Done the changes

https://codereview.chromium.org/2019993003/diff/80001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/svg/custom/SVGRect-without-rx-or-ry-in-css-style-expected.svg
(right):

https://codereview.chromium.org/2019993003/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/custom/SVGRect-without-rx-or-ry-in-css-style-expected.svg:3:
ry="10"
On 2016/06/01 10:43:09, fs wrote:
> Since 'ry', from the inline style, would override the 'ry', from the
> presentation attribute, this should render as if rx=ry=0. But I suggest adding
a
> 'rx' (different from the 'ry' value). Ditto for the other case. (You need to
add
> support for parsing 'auto' from CSS as well.)

Done.

[fs, 2016-06-01 13:22:30]

lgtm

[Shanmuga Pandi, 2016-06-01 13:33:14]

The CQ bit was checked by shanmuga.m@samsung.com

[commit-bot: I haz the power, 2016-06-01 13:33:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2019993003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2019993003/100001

[commit-bot: I haz the power, 2016-06-01 19:41:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-01 19:41:13]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Shanmuga Pandi, 2016-06-02 06:14:07]

The CQ bit was unchecked by shanmuga.m@samsung.com

[Shanmuga Pandi, 2016-06-02 06:14:13]

The CQ bit was checked by shanmuga.m@samsung.com

[commit-bot: I haz the power, 2016-06-02 06:14:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2019993003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2019993003/100001

[Shanmuga Pandi, 2016-06-02 06:15:27]

The CQ bit was unchecked by shanmuga.m@samsung.com

[Shanmuga Pandi, 2016-06-02 06:15:52]

The CQ bit was checked by shanmuga.m@samsung.com

[commit-bot: I haz the power, 2016-06-02 06:16:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2019993003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2019993003/100001

[commit-bot: I haz the power, 2016-06-02 07:46:57]

Description was changed from

==========
Set "auto" as default for rx and ry

Set initial value as "auto" for rx and ry.

BUG=576811
==========

to

==========
Set "auto" as default for rx and ry

Set initial value as "auto" for rx and ry.

BUG=576811
==========

[commit-bot: I haz the power, 2016-06-02 07:46:58]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-06-02 07:48:05]

Description was changed from

==========
Set "auto" as default for rx and ry

Set initial value as "auto" for rx and ry.

BUG=576811
==========

to

==========
Set "auto" as default for rx and ry

Set initial value as "auto" for rx and ry.

BUG=576811

Committed: https://crrev.com/c9cc8c9d40aa52810ee6b29a0717948cfad5c20a
Cr-Commit-Position: refs/heads/master@{#397332}
==========

[commit-bot: I haz the power, 2016-06-02 07:48:06]

Patchset 6 (id:??) landed as
https://crrev.com/c9cc8c9d40aa52810ee6b29a0717948cfad5c20a
Cr-Commit-Position: refs/heads/master@{#397332}