Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 2019983002: Roll third_party/double_conversion (Closed)

Created:
4 years, 6 months ago by Søren Gjesse
Modified:
4 years, 6 months ago
Reviewers:
ricow1, floitsch
CC:
dartino-code-reviews_googlegroups.com
Base URL:
git@github.com:dartino/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Roll third_party/double_conversion * Roll to 56a04575a474b929a4aa4fb72d83d46c8a93f294. * Added README.google with local modicucation details R=ricow@google.com, floitsch@google.com BUG= Committed: https://github.com/dartino/sdk/commit/6cb3ef691bd9d3e98564157b0ac9ae2867e44bde

Patch Set 1 #

Patch Set 2 : Minor update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -5 lines) Patch
A third_party/double-conversion/README.google View 1 1 chunk +30 lines, -0 lines 0 comments Download
M third_party/double-conversion/src/bignum.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/double-conversion/src/bignum.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/double-conversion/src/cached-powers.cc View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/double-conversion/src/double-conversion.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/double-conversion/src/utils.h View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Søren Gjesse
4 years, 6 months ago (2016-05-30 07:23:48 UTC) #1
ricow1
lgtm
4 years, 6 months ago (2016-05-30 07:29:37 UTC) #3
Søren Gjesse
4 years, 6 months ago (2016-05-30 08:03:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
6cb3ef691bd9d3e98564157b0ac9ae2867e44bde (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698